ModelicaSystem - use OMCPath #322
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents * fix some type hint issues in setInput() * prepare for definition via dictionary replacing 'a=b' and '[a=b, c=d]' style
* rename from setMethodHelper() * use _prepare_inputdata() * cleanup code to align with new input as dict[str, str] * setInput() is a special case
* replace eval() with ast.literal_eval() as a saver version * use _prepare_input_data() * simplify code
This method is used to set input values. It can be called with a sequence of input name and assigning corresponding values as arguments as show in the example below. Compared to other set*() methods this is a special case as value could be a list of tuples - these are converted to a string in _prepare_input_data() and restored here via ast.literal_eval().
* not working: 3.10 * working: 3.12
syntron
force-pushed
the
ModelicaSystem_use_OMCPath
branch
from
466740c to
3278b53
Compare
* use as input str or os.PathLike; the later covers all pathlib objects * rename _tempdir to _work_dir * rename setTempDirectory() => setWorkDirectory() * setWorkDirectory() sets the work dir and also returns its path * use setWorkDirectory() within code; this allows to add special handling to the function if needed
background: if OMCPath will be used, it is not available
background: open() is not available if OMCPath is used
error: "unlink" of "OMCPathReal" does not return a value (it only ever returns None) [func-returns-value]
* define file name based on result file name & Path * simplify code
…able * if this happens, the result would be unexpected * fail early, fail hard to indicate this to the user * simplify code
syntron
force-pushed
the
ModelicaSystem_use_OMCPath
branch
2 times, most recently
from
2608ffc to
0b986be
Compare
… this code (int or str)
* allow different ways to define the path
remove pathlib - use OMCPath and (for type hints) os.PathLike
syntron
force-pushed
the
ModelicaSystem_use_OMCPath
branch
from
0b986be to
74f1c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big step on the way to run ModelicaSystem not only locally; see #315 item (1):
based on PR #317, #314, #320 and #321