Skip to content

[OMCProcessDocker*] update exception message - make them specific to … #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

[OMCProcessDocker*] update exception message - make them specific to … #336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28ca381
[OMCProcessDocker*] update exception message - make them specific to …
syntron Jul 1, 2025
9da0c23
Merge branch 'master' into OMCProcessDocker
adeas31 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions OMPython/OMCSession.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,9 +764,8 @@ def _docker_omc_cmd(
if sys.platform == "win32":
extraFlags = ["-d=zmqDangerousAcceptConnectionsFromAnywhere"]
if not self._interactivePort:
raise OMCSessionException("docker on Windows requires knowing which port to connect to. For "
"dockerContainer=..., the container needs to have already manually exposed "
"this port when it was started (-p 127.0.0.1:n:n) or you get an error later.")
raise OMCSessionException("docker on Windows requires knowing which port to connect to - "
"please set the interactivePort argument")

if sys.platform == "win32":
if isinstance(self._interactivePort, str):
Expand Down Expand Up @@ -892,9 +891,10 @@ def _docker_omc_cmd(self, omc_path_and_args_list) -> list:
if sys.platform == "win32":
extraFlags = ["-d=zmqDangerousAcceptConnectionsFromAnywhere"]
if not self._interactivePort:
raise OMCSessionException("docker on Windows requires knowing which port to connect to. For "
"dockerContainer=..., the container needs to have already manually exposed "
"this port when it was started (-p 127.0.0.1:n:n) or you get an error later.")
raise OMCSessionException("Docker on Windows requires knowing which port to connect to - "
"Please set the interactivePort argument. Furthermore, the container needs "
"to have already manually exposed this port when it was started "
"(-p 127.0.0.1:n:n) or you get an error later.")

if isinstance(self._interactivePort, int):
extraFlags = extraFlags + [f"--interactivePort={int(self._interactivePort)}"]
Expand Down
Loading