Skip to content

fix: improve username generation to avoid conflicts with existing use… #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: improve username generation to avoid conflicts with existing use… #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions server/src/user/user.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,15 @@ export class UserService {
.replace(/[\u0300-\u036f]/g, '')
.replace(/[^a-zA-Z0-9_]/g, '');

// Find if there's already a user with the same username
let nameTaken = await this.usernameExists(baseUsername);
let newUsername = baseUsername;
let counter = 1;

while (nameTaken) {
const newUsername = `${baseUsername}.${Math.floor(Math.random() * 100)}`;
nameTaken = await this.usernameExists(newUsername);
// Check if the base username already exists
while (await this.usernameExists(newUsername)) {
newUsername = `${baseUsername}_${counter}`;
counter++;
}

return baseUsername;
return newUsername;
}
}