feat: song search #59
Conversation
…ponding tests - Added getFeaturedSongs method to SongService to retrieve featured songs across various timespans. - Implemented tests for getFeaturedSongs to ensure correct functionality and handling of empty results. - Removed SongBrowser module and related files as part of the refactor to streamline the service structure. - Introduced new PageDto class for pagination handling in the database module.
- Implemented various query modes in getSongList method to support fetching featured, recent, category-based, and random songs. - Added error handling for invalid query parameters and improved response types using PageDto. - Introduced searchSongs method for keyword-based song searches with pagination. - Updated Swagger documentation to reflect new query parameters and response structures.
- Introduced for improved query handling, allowing filtering by title, category, uploader, and sorting by various criteria. - Updated method in to support new query parameters and sorting logic. - Added new endpoints for fetching featured songs and available categories. - Refactored frontend components to align with updated API endpoints and enhance song search functionality. - Improved error handling and loading states in the frontend for better user experience.
- Introduced a new SearchButton component for searching songs. - Integrated the SearchButton into the Header component for improved accessibility. - Implemented search query handling and routing to the search results page.
…ld into feature/song-search
There was a problem hiding this comment.
Awesome work! I'm so excited to ship this feature 🤩
I've left a few considerations in the review comments; not all of them may be actionable atm.
A few points we've yet to work on:
- I'll work on touching up the frontend presentation so it's more consistent with our current design.
- Recent songs seem not to be loading locally for me
- Are the tests still supposed to be failing?
| query.page, | ||
| query.limit, | ||
| ); | ||
| return new PageDto<SongPreviewDto>({ |
There was a problem hiding this comment.
Could this part of the code be extracted outside of the if clause? It's repeated exactly for each query mode :)
EDIT: I mean the return new PageDto({...}) part. For some reason I highlighted completely wrong lines.
| try { | ||
| const response = await axiosInstance.get<FeaturedSongsDto>( | ||
| '/song-browser/featured', | ||
| '/song/featured', |
There was a problem hiding this comment.
Isn't this route supposed to clash with the GET /song/:id endpoint? Is this currently the case, or is there some precedence order going on to prevent this from happening?
Our song IDs are 10 characters long, spanning A-Za-z0-9, but were they 8 characters long, featured could technically be a valid song ID.
| try { | ||
| const response = await axiosInstance.get<Record<string, number>>( | ||
| '/song-browser/categories', | ||
| '/song/categories', |
There was a problem hiding this comment.
oop, there we go - categories, a perfectly valid song id! xD
Though I believe the chance of this happening is quite unlikely... 1 in 62^10 or something?
|
Pictures of the current frontend (courtesy of @tomast1337!): 
|
No description provided.