In scheduler/client.c 'for (char *start = ...' is only allowed in C99 mode

[jsmeix]

Since
a7eda84
from #974
there are now two 'for' loop initial declarations

for (char *start = ...

which are only allowed in C99 mode.
When not in C99 mode one gets a compiler

error: 'for' loop initial declarations are only allowed in C99 mode

Has C99 mode become mandatory to compile CUPS?

I ask because when I compile CUPS 2.4.10
in a SUSE SLES12 SP5 build environment,
I get the above compiler error.

[jsmeix]

avoid_C99_mode_for_loop_initial_declarations.txt

I use this patch (uploaded here with *.txt file name)
to compile CUPS 2.4.10 in a SUSE SLES12 SP5 build environment.

[michaelrsweet]

No, prior to CUPS 2.5 we don't require C99 support. We should update this code to not depend on loop variable declarations...

[zdohnal]

@jsmeix Thank you for the patch! I saw you double-reference the pointer - IIUC it is not correct, can you check if the patch in the attached PR works for you? I've used the existing ptr instead, so it should save memory.

[jsmeix]

@zdohnal
thank you!

Yes, my patch is faulty.
But as long as it compiles all must be "allright" ;-) cf.
https://libquotes.com/linus-torvalds/quote/lbl0v5c

I replaced my patch with your upstream fix in
a2b8872

FYI:
The actual reason for my fault was "focus of mind".
At that time I was not at all interested in that new issue.
It got in my way while trying to get something different done.
So I only wanted to get that annoyance somehow out of my way.
Or simply put: Mental stack overflow.