httpAddrConnect2: Check for error if POLLHUP is in valid revents #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Dec 7, 2023
zdohnal
force-pushed
the
check-for-soerror
branch
from
1491f46
to
ef36588
Compare
|
Updated PR based on the feedback. |
michaelrsweet
requested changes
Dec 13, 2023
Some Linux kernel versions put POLLOUT|POLLHUP into revents when client tries to connect with httpAddrConnect2(), which makes the connection fail. Let's check the option SO_ERROR before scratching the attempt - if there is no error, remove POLLHUP from revents. I've re-purposed previously Solaris-only code to be used everywhere if the conditions are met - this should prevent bigger delays than necessary. Slightly different issue than OpenPrinting#827, but with similar symptoms (kernel sending POLLOUT|POLLHUP).
zdohnal
force-pushed
the
check-for-soerror
branch
from
68b9052
to
289685f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Linux kernel versions put POLLOUT|POLLHUP into revents when client tries to connect with
httpAddrConnect2(), which makes the connection fail.Let's check the option SO_ERROR before scratching the attempt - if there is no error, remove POLLHUP from revents.
I've re-purposed previously Solaris-only code to be used everywhere if the conditions are met - this should prevent bigger delays than necessary.
Slightly different issue than #827, but with similar symptoms (kernel sending POLLOUT|POLLHUP).