Skip to content

Commit

Permalink
Implement ReloadAmmoDelay multiplier.
Browse files Browse the repository at this point in the history
  • Loading branch information
MustaphaTR committed Jun 17, 2019
1 parent c8a42cb commit 8b5f12a
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 1 deletion.
31 changes: 31 additions & 0 deletions OpenRA.Mods.Common/Traits/Multipliers/ReloadAmmoDelayMultiplier.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#region Copyright & License Information
/*
* Copyright 2007-2019 The OpenRA Developers (see AUTHORS)
* This file is part of OpenRA, which is free software. It is made
* available to you under the terms of the GNU General Public License
* as published by the Free Software Foundation, either version 3 of
* the License, or (at your option) any later version. For more
* information, see COPYING.
*/
#endregion

namespace OpenRA.Mods.Common.Traits
{
[Desc("Modifies the reload time of ammo pools on this actor.")]
public class ReloadAmmoDelayMultiplierInfo : ConditionalTraitInfo
{
[FieldLoader.Require]
[Desc("Percentage modifier to apply.")]
public readonly int Modifier = 100;

public override object Create(ActorInitializer init) { return new ReloadAmmoDelayMultiplier(this); }
}

public class ReloadAmmoDelayMultiplier : ConditionalTrait<ReloadAmmoDelayMultiplierInfo>, IReloadAmmoModifier
{
public ReloadAmmoDelayMultiplier(ReloadAmmoDelayMultiplierInfo info)
: base(info) { }

int IReloadAmmoModifier.GetReloadAmmoModifier() { return IsTraitDisabled ? 100 : Info.Modifier; }
}
}
4 changes: 3 additions & 1 deletion OpenRA.Mods.Common/Traits/ReloadAmmoPool.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public override void RulesetLoaded(Ruleset rules, ActorInfo ai)
public class ReloadAmmoPool : PausableConditionalTrait<ReloadAmmoPoolInfo>, ITick, INotifyCreated, INotifyAttack, ISync
{
AmmoPool ammoPool;
IReloadAmmoModifier[] modifiers;

[Sync]
int remainingTicks;
Expand All @@ -56,6 +57,7 @@ public ReloadAmmoPool(ReloadAmmoPoolInfo info)
void INotifyCreated.Created(Actor self)
{
ammoPool = self.TraitsImplementing<AmmoPool>().Single(ap => ap.Info.Name == Info.AmmoPool);
modifiers = self.TraitsImplementing<IReloadAmmoModifier>().ToArray();
remainingTicks = Info.Delay;
}

Expand All @@ -79,7 +81,7 @@ protected virtual void Reload(Actor self, int reloadDelay, int reloadCount, stri
{
if (!ammoPool.FullAmmo() && --remainingTicks == 0)
{
remainingTicks = reloadDelay;
remainingTicks = Util.ApplyPercentageModifiers(reloadDelay, modifiers.Select(m => m.GetReloadAmmoModifier()));
if (!string.IsNullOrEmpty(sound))
Game.Sound.PlayToPlayer(SoundType.World, self.Owner, sound, self.CenterPosition);

Expand Down
3 changes: 3 additions & 0 deletions OpenRA.Mods.Common/TraitsInterfaces.cs
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,9 @@ public interface IFirepowerModifier { int GetFirepowerModifier(); }
[RequireExplicitImplementation]
public interface IReloadModifier { int GetReloadModifier(); }

[RequireExplicitImplementation]
public interface IReloadAmmoModifier { int GetReloadAmmoModifier(); }

[RequireExplicitImplementation]
public interface IInaccuracyModifier { int GetInaccuracyModifier(); }

Expand Down

0 comments on commit 8b5f12a

Please sign in to comment.