Uncloaking based on unit HP is hard coded

[forcecore]

Hi, I'm trying to make ants keep burrowed to the ground even when the ant is in critical damage state. It seems the related code is hardcoded.

OpenRA/OpenRA.Mods.Common/Traits/Cloak.cs

Line 106 in 285e9a8

if (damageDisabled || Info.UncloakOn.HasFlag(UncloakType.Damage))

void INotifyDamageStateChanged.DamageStateChanged(Actor self, AttackInfo e)
{
    damageDisabled = e.DamageState >= DamageState.Critical;
    if (damageDisabled || Info.UncloakOn.HasFlag(UncloakType.Damage))
        Uncloak();
}

No SC1 Dark Templars for OpenRA :(

[forcecore]

UncloakType.Damage seems ambiguous to me. If it is supposed to reveal a clocked unit when the unit has been hit by something, then a better name would be OnHit or OnDamage. In this case, damageDisabled is hard coded.

On the other hand, if it was supposed to mean damage state, then || operator should become &&, and the could be renamed to CriticalDamageState.

[pchote]

The damageDisabled bit can be removed completely, mods that want to disable based on damage state can do this using conditions.

[forcecore]

Sounds like an easy fix. I'll branch from bleed and submit a PR when done. Both Cloak.cs and YAML files.

[forcecore]

PR #12759 accepted, closing.

[pchote]

Note that you can make GitHub close issues automatically by putting e.g. "Fixes #12741" in a PR description.