Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter activity does not account for moving Targets. #14365

Closed
pchote opened this issue Nov 15, 2017 · 2 comments · Fixed by #16150
Closed

Enter activity does not account for moving Targets. #14365

pchote opened this issue Nov 15, 2017 · 2 comments · Fixed by #16150
Assignees
Labels

Comments

@pchote
Copy link
Member

pchote commented Nov 15, 2017

From #13699:

The Enter code does not account for the target moving after the movement (e.g. Drag) has started. If the target is moving then the unit will move to the original target position, notice that it is no longer there, and then fail/cancel itself.

What we really want here to fix this properly is to fix the IMove.MoveIntoTarget implementations to deal with moving targets. This means that Drag etc can adjust themselves to move always towards the actual position of the target. For this to work well we would need to introduce a WDist targetMoveLimit to the method call that can abort the activity if the target is moving too far/fast from the original location. This then covers the Hijacker issue plus any visual glitches that could be caused by the target moving too fast.

@ghost
Copy link

ghost commented Nov 24, 2018

The hijacker part should be fixed by #15661 (comment).

@pchote pchote added this to the Next Release milestone Jan 31, 2019
@pchote
Copy link
Member Author

pchote commented Jan 31, 2019

This will come for free with my fix for #16139. Adding to the milestone so that we don't forget to test and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants