Engineers sometime refuse to capture actors under fog of war

[ghost]

Reported by player eskimo on the forums:

Noticed a targeting issue with the engineer on top right oil of A Nuclear Winter. Engineers can't target Construction Yards through Fog of War, unless you have a unit there who is in view of it at the time of the Engineer clicking the Con Yard. I presume this is just because of the new Fog of War targeting vs MCV/ConYard code.

I can confirm both issues ( engineers refuse to capture conyard under fog / sometimes refuse to capture oil derricks). It seems the issue with oil derricks only appears if there are other actors in close proximity, like oil barrels on the mentioned map.

[netnazgul]

Is the first part related to "can't target oils when they are near the trees" bug? Because that's an old one I think noone really reported before.

[pchote]

This is probably going to require #16048.

[pchote]

I have a work in progress fix on my fog-aware-enter branch. Capturing static structures works well, but mobile targets (hijacking) seems to be glitchier than on bleed. I will file a PR after i'm confident in the Hijacker behaviour and have ported most of the other Enter subclasses to use the new backend.