SAM site stays after being sold during low-power

[deniz1a]

It was targeting a plane while looking like that. I had to press sell multiple times before it was sold properly. This is in release-20141029. Might be related to #6076.

[pevers]

Reproducable:

1. Attack SAM site from enemy player that is powered down with AIRFORCE.
2. Sell SAM site on enemy side.

Doesn't matter if the player have low-power or that he just powered the SAM site down, effect is the same.

[penev92]

Thanks. Now that we have a reproduce-case, maybe someone can fix it :)

[jabbink]

This behaviour is induced by the AttackFollow Activity, which the SAM site has every tick, even when powered down.

Subsequently https://github.com/OpenRA/OpenRA/blob/bleed/OpenRA.Mods.Common/Traits/Attack/AttackFollow.cs#L74 will return early without going to the next activity (being sold).

I changed that line to return NextActivity, and selling a powered down, attacking SAM site worked fine. I am not sure what other side effects this has as I guess there is a reason why a disabled actor in AttackFollow mode should not do anything else.

[penev92]

First thing that comes to mind is an EMP-ed tank continuing to chase a target after the EMP effect wears off. But you are on a good path.
Consider also clearing the activity queue when a sell order is issued.

[obrakmann]

I cannot reproduce this on -playtest at all. Is this still an issue, or has it been fixed by accident?

[pevers]

@obrakmann Thats strange as I can still reproduce this on the latest bleed.

[pevers]

I think I found out why it isn't always repoducible. In

https://github.com/OpenRA/OpenRA/blob/bleed/OpenRA.Mods.Common/Traits/Sellable.cs#L46

All the activities are cancelled before selling the building. But the animation will take some time to sell, so a new attack activity can be placed in the queue blocking the eventually sell (after the animation). I have proposed another fix in #7544,

[chrisforbes]

Selling should take the building lock. I think we shouldn't be queuing any
attack stuff if the building is locked.

• OR -

Is this not right? It would mean that capture in progress prevents firing
too. This would have balance implications.

On Mon, Mar 2, 2015 at 7:42 AM, Peter Evers notifications@github.com
wrote:

@obrakmann https://github.com/obrakmann Thats strange as I can still
reproduce this on the latest bleed.

—
Reply to this email directly or view it on GitHub
#7442 (comment).

[pevers]

@chrisforbes I think that would indeed mean that capturing a building would immediately disable attack moves which isn't preferred in my opinion

I outputted the queue activity in this situation:

cancelled all activity on sell
queue OpenRA.Mods.Common.Traits.AttackFollow+AttackActivity
queue OpenRA.Mods.Common.Activities.Sell

So preventing attack activities on disabled buildings may fix this bug and also improve a lot on efficiency I think. I'll try that out now.

[phrohdoh]

Closed with #7544.