Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HazMat suites to Tiberian Dawn #10616

Merged
merged 4 commits into from
Feb 3, 2016
Merged

Conversation

Mailaender
Copy link
Member

Closes #5030.

@pchote
Copy link
Member

pchote commented Jan 26, 2016

Great! This is something that has bugged me for ages. :+0.5: because the idea and yaml look fine, but I haven't tested it yet.

@@ -204,6 +204,11 @@
CargoType: Infantry
HiddenUnderFog:
PoisonedByTiberium:
UpgradeTypes: hazmatsuites
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, suits or suit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, fixed.

@pchote
Copy link
Member

pchote commented Jan 30, 2016

Works as advertised, so 👍

A followup pr should add some kind of selection decoration to infantry to indicate that the upgrade is active. This otherwise remains undiscoverable.

@GraionDilach
Copy link
Contributor

I made a pip.

https://copy.com/Ty6WXfxYzxT21nSS

@obrakmann
Copy link
Contributor

Thanks @GraionDilach, I added them in Mailaender#56

screenshot from 2016-01-31 16 54 47

@Mailaender
Copy link
Member Author

Awesome, thanks! Can you also make those for hospital healing?

@pchote
Copy link
Member

pchote commented Jan 31, 2016

I believe that RA has a medic icon we can use for that.

@phrohdoh
Copy link
Member

This is looking pretty sharp!

@GraionDilach
Copy link
Contributor

I believe that RA has a medic icon we can use for that.

Indeed it had one. I took it out, converted to TD palette and cropped the canvas.
https://copy.com/MDuTLsTOpJoRuTxo

@Mailaender
Copy link
Member Author

Thanks. Submitted it in #10680.

@GraionDilach
Copy link
Contributor

Come to think of it, this will be wrong, they will overlap with each other/ranks.

@Mailaender
Copy link
Member Author

They work together with ranks although with those tiny infantry it is already quite edgy. I added a Description which can be used in future tooltips or #3788.

@pchote
Copy link
Member

pchote commented Feb 2, 2016

You could set it up with upgrades to render the bio glyph in a different position if the hospital upgrade is already applied.

@GraionDilach
Copy link
Contributor

My suggestion would be to shift hazmat and hospital into topright corner - that worked well in YR (for hosp and machine shop) and with the disguise pip in our RA/TS mod.

@obrakmann
Copy link
Contributor

Let's do the fine-tuning in the spin-off PR. For now, this works as advertised. 👍

obrakmann added a commit that referenced this pull request Feb 3, 2016
Added HazMat suites to Tiberian Dawn
@obrakmann obrakmann merged commit 1dbb754 into OpenRA:bleed Feb 3, 2016
@obrakmann
Copy link
Contributor

Changelog

@Mailaender Mailaender deleted the bio-immunity branch February 3, 2016 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants