Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ClosestEdgeCell and a ClosestMatchingEdgeCell function to lua #10917

Merged
merged 2 commits into from
Mar 30, 2016

Conversation

abcdefg30
Copy link
Member

Makes use of the new methods introduced in #10851.

@obrakmann
Copy link
Contributor

👍

@@ -19,6 +19,16 @@ end
SendJeeps = function()
Reinforcements.Reinforce(player, JeepReinforcements, InsertionPath, DateTime.Seconds(2))
Media.PlaySpeechNotification(player, "ReinforcementsArrived")

-- TESTCASE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This testcase doesn't seem to work. Where and when are the dogs supposed to spawn?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nevermind. I didn't realize that you got jeep reinforcements later in the mission.

@pchote
Copy link
Member

pchote commented Mar 26, 2016

👍 after you remove the testcase and rebase to fix appveyor.

@phrohdoh
Copy link
Member

Another fixup if we get to this before @abcdefg30 returns.

@abcdefg30
Copy link
Member Author

Removed the testcase.

@phrohdoh
Copy link
Member

👍

@obrakmann obrakmann merged commit 4c8b13e into OpenRA:bleed Mar 30, 2016
@obrakmann
Copy link
Contributor

Changelog

@abcdefg30 abcdefg30 deleted the luaClosedCell branch March 30, 2016 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants