Add support for playing a "LoseNotification" to the old owner through CaptureNotification #11142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the LocalPlayer check if we only play the sound to the new owner, and captor.Owner == newOwner in this case.
| Game.Sound.PlayNotification(self.World.Map.Rules, captor.World.LocalPlayer, "Speech", info.Notification, faction); | ||
| Game.Sound.PlayNotification(self.World.Map.Rules, newOwner, "Speech", info.Notification, faction); | ||
|
|
||
| var looseFaction = info.NewOwnerVoice ? newOwner.Faction.InternalName : oldOwner.Faction.InternalName; |
There was a problem hiding this comment.
This wants to be info.LooseNewOwnerVoice I assume.
|
Fixed. |
|
I think you guys want "Lose" not "Loose".
|
|
Yeah, already fixed that, just not the descriptions and commit messages... |
abcdefg30
changed the title
… CaptureNotification
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want this for at least ra2: OpenRA/ra2#187 (comment)
The default being
nullwon't cause trouble asPlayNotificationalready catches that.