Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tech building notifications #187

Closed
wants to merge 303 commits into from

Conversation

Mailaender
Copy link
Member

Followup of #77.

MustaphaTR and others added 30 commits January 15, 2016 18:17
The original didn't have an undeploy cursor
Added support for installing this into the support folder
Add an undeploy cursor and make construction yards use it
Fixed the TEMPERATE map import and clean up the maps
to fix ra2/chrome/tooltips.yaml refers to a logic object
`CountryTooltipLogic` that does not exist
Added more variations to building explosions
Mailaender and others added 21 commits March 20, 2016 19:24
Bleed commit:  728bad95
Update to latest bleed (728bad9565d39be189a10c86b0567b584f313aef)
Added the Guard Border Crossing
and torpedos won't hit high bridges.
Use Inheritance on weapons where possible.
Removed custom Falloff value from Harrier/Black Eagle which caused them delivering 10 times of their supposed damage.
Replaced piff (singular bullet hit) animation with piffpiff (multiple bullet hit) animation where appropriate.
Added a comment to Flak Trooper AA weapon explaining the nerf is caused by Westwood.
Misc ImpactType cleanup on CreateEffectWarheads.
Added missing tesla hit animation to Tesla Trooper and Tesla Coil.
Fixed Crazy Ivan eliteweapon crashing due to an ExplosionPalette typo.
Fix aircraft not showing up on radar
@@ -159,6 +159,10 @@
Range: 4c0
Tooltip:
Description: Tech Building
CaptureNotification:
Notification: TechBuildingCaptured
ActorLostNotification:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this play when actor is destroyed? In RA2 this only plays when anyone else captures our Tech Building iirc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't play at all when the building is captured, but only when it got destroyed.
We might want to expand CaptureNotification here to play a sound to the old owner
(if that isn't already possible in some way).

@MustaphaTR
Copy link
Member

As I remembered, there's different notifications for different structures in original RA2...

It was in YR. RA2 had all same notifications.

@abcdefg30
Copy link
Member

I think we should wait for OpenRA/OpenRA#11142 here.

@Mailaender
Copy link
Member Author

Superseded by #219.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants