Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent non-combatant players from receiving units from crate pickups #11574

Merged
merged 1 commit into from
Jul 10, 2016
Merged

Prevent non-combatant players from receiving units from crate pickups #11574

merged 1 commit into from
Jul 10, 2016

Conversation

obrakmann
Copy link
Contributor

No description provided.

@pchote
Copy link
Member

pchote commented Jul 3, 2016

Looks reasonable to me, but not tested :+0.5:

@phrohdoh
Copy link
Member

phrohdoh commented Jul 6, 2016

Is there any reason the same shouldn't be done to DuplicateUnitCrateAction?

@obrakmann
Copy link
Contributor Author

obrakmann commented Jul 6, 2016 •
edited
Loading

A couple:

  1. I forgot about it ;)
  2. It wouldn't cause civilians to get units that they don't have access to. They just get another civ unit, which I'm ok with.

@GraionDilach
Copy link
Contributor

I'm not certain if I'd like visceroids getting duplicated.

@obrakmann obrakmann force-pushed the fix_non-combatant-unitcratepickup branch from 7c4696f to b080417 Compare July 8, 2016 11:24
@obrakmann
Copy link
Contributor Author

Good point, updated.

@GraionDilach
Copy link
Contributor

👍

@Mailaender Mailaender merged commit 90439ac into OpenRA:bleed Jul 10, 2016
@Mailaender
Copy link
Member

No more random neutral MCVs appearing on the battlefield. ;)

@Mailaender
Copy link
Member

Changelog

@obrakmann obrakmann deleted the fix_non-combatant-unitcratepickup branch July 23, 2016 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@obrakmann @pchote @phrohdoh @GraionDilach @Mailaender @abcdefg30