Added Scott's Allies04 co-op multiplayer mission as "Infiltration" #11702

Mailaender · 2016-07-24T09:04:21Z

@ScottNZ's original mission converted from the C# mission code found in release-20131223. My favorite one as it tells a good story without relying on too much text and has a nice attention to detail. The intro sequence is very hard, but it works well in co-operative settings with one player already guiding the newbie. It is also exciting (and hilarious) for spectators to watch.

Regarding features it was way ahead of it's time, but relied a lot on non-reusable hacks and suffered from missing engine features. It even had civilians walking around randomly which we just introduced in #11520 for all maps and mods. I managed to replace all expensive checks with triggers and made use of the global palette effect from #7863 to create the dawn lighting.

This should be very faithful to the original. The only behavioral change I introduced is to let the spy "hotwire" (externally capture) the truck. Afterwards all spies can enter regularly. This avoids fragile script workarounds. Capturing would destroy the spy actor and LoadPassenger will duplicate it, leading to an inconsistent world state.

pchote · 2016-07-24T10:19:03Z

We used to have logic in place that lets a spy infiltrate an actor without being destroyed.

abcdefg30 · 2016-07-24T11:12:12Z

OpenRA.Mods.Common/Scripting/Global/MediaGlobal.cs

@@ -207,6 +207,13 @@ public void Debug(string text)
 			Game.Debug(text);
 		}

+		[Desc("Write a message into debug.log")]
+		public void DebugLog(string text)


Isn't this kind of redundant to the normal Debug (see method above)?

No, that uses Game.Debug which displays it in-game. If you want to dump a large amount of data the chat log would get spammed and you can't search it.

Isnt this redundant to the print builtin that we overrode for this purpose?

As discussed in IRC, please remove this and use print() instead.

abcdefg30 · 2016-07-24T12:54:06Z

I think we should mention that you need to capture a supply truck. Maybe in the description with just something like The best way to get in for our spies is to hijack a supply truck.?

abcdefg30 · 2016-07-24T12:54:36Z

Or even add an extra objective for it.

abcdefg30 · 2016-07-24T13:05:29Z

mods/ra/maps/infiltration/rules.yaml

+
+LST.Unselectable.UnloadOnly:
+	Inherits: LST
+	Buildable:


What is this for?

Seems like you forgot to add Prerequisites: ~disabled below.

Mailaender · 2016-07-24T16:08:06Z

Fixed all the remarks.

pchote · 2016-07-24T16:13:46Z

OpenRA.Mods.Common/Scripting/Properties/GeneralProperties.cs

@@ -59,6 +59,9 @@ public Player Owner

 			set
 			{
+				if (value == null || !(value is Player))


Do you have a repro case of this being called with !(value is Player)? That shouldn't be possible.

This is a wild guess to be honest. Even the null check. You suggested on IRC to add this. I can't really prove this fixes anything and I believe the Lua bridge will crash on a lower level part if you throw wrong parameters on it "can't convert stupid scripter typo without naming even the variable just telling `nil was received to LuaValue in line number 30 in sandbox.lua". I also tried to improve the stacktrace a bit in those situations as it is really annyoing, but failed. Will remove this and hope for @Unit158 to finish #9086.

obrakmann · 2016-08-01T19:40:58Z

Here you'll want to set the Cooperative flag on MissionObjectives as well, for the same reason as in Allies03.

Mailaender · 2016-08-01T19:49:59Z

I had trouble with the Cooperative flag on #11679 as it doesn't seem to work well with shared/duplicated objectives, which is the case here as well I assume.

obrakmann · 2016-08-03T18:34:48Z

What problems exactly? It should just work.

obrakmann · 2016-08-25T12:57:11Z

OpenRA.Mods.Common/Scripting/Properties/SellableProperties.cs

+		public SellableProperties(ScriptContext context, Actor self)
+			: base(context, self)
+		{
+			sellable = self.Trait<Sellable>();


You don't really need to cache this, it will only be used once for every actor.

What if we sell many actors at once? Wouldn't that create a tiny lag without caching?
What I actually want to says, now that we already cache it, do we really want to revert that back?

Arguing over micro-optimizations is a bit silly, but I think its fair to say that an actor will be sold on average zero times (or at least much closer to zero than one). Caching it here means doing this lookup for all buildings, but doing it in Sell means doing it only on the buildings that you sell.

Ah well. Then nvm my comment.

obrakmann · 2016-08-25T13:31:35Z

Looks otherwise fine so far. The mission is fucking annoying in the beginning, though, with all the dogs around and you having no idea where to go. I eventually looked at the map in the editor and then knew where I had to go, but still never got there due to the dogs. How about removing some on easier skill levels?

abcdefg30 · 2016-08-27T15:11:14Z

How about removing some on easier skill levels?

We could also add cameras, like in allies05a on easier difficulties.

abcdefg30 · 2016-08-31T12:20:40Z

I left my remarks at Mailaender#59.

Mailaender · 2016-08-31T20:16:38Z

Thanks. Squashed them in.

abcdefg30 · 2016-08-31T20:34:43Z

Looks good to me now (after travis is fixed). 👍 / ✅

abcdefg30 · 2016-09-02T15:31:53Z

Mailaender#60 fixes travis.

Mailaender · 2016-09-03T05:22:30Z

And another crash fixed Mailaender#61. Thanks.

obrakmann · 2016-09-04T12:45:13Z

mods/ra/maps/infiltration/infiltration.lua

+
+	Utils.Do(sovietbuildings, function(sovietbuilding)
+		Trigger.OnDamaged(sovietbuilding, function(building)
+			if building.Health < building.MaxHealth * 3/4 then


This needs an owner check. if building.Owner ~= soviets then return

obrakmann · 2016-09-04T13:32:43Z

👍 after those things have been addressed

Mailaender · 2016-09-04T16:15:20Z

Updated.

obrakmann · 2016-09-04T16:42:47Z

Changelog

Mailaender mentioned this pull request Jul 24, 2016

Port missions to the new Lua API #5490

Closed

2 tasks

abcdefg30 reviewed Jul 24, 2016
View reviewed changes

abcdefg30 added the PR: Fixup requested label Jul 24, 2016

Mailaender force-pushed the infiltration-mission branch 2 times, most recently from 227aef3 to 98bdbf6 Compare July 24, 2016 16:07

Mailaender removed the PR: Fixup requested label Jul 24, 2016

pchote reviewed Jul 24, 2016
View reviewed changes

Mailaender force-pushed the infiltration-mission branch from 98bdbf6 to ecb016e Compare July 24, 2016 19:17

obrakmann added this to the Next release milestone Aug 25, 2016

obrakmann reviewed Aug 25, 2016
View reviewed changes

Mailaender added the PR: Fixup requested label Aug 25, 2016

Mailaender force-pushed the infiltration-mission branch from ecb016e to eb79591 Compare August 27, 2016 15:48

abcdefg30 added PR: Changes requested and removed PR: Needs +2 labels Aug 31, 2016

Mailaender force-pushed the infiltration-mission branch from 01e54ba to f726a06 Compare August 31, 2016 20:16

Mailaender removed the PR: Changes requested label Aug 31, 2016

abcdefg30 added the PR: Needs +2 label Aug 31, 2016

abcdefg30 added the PR: Fixup requested label Sep 2, 2016

Mailaender added 2 commits September 2, 2016 21:59

Add Sell to the Lua API.

e3df47d

Add OnSelling and OnSold to the Lua API.

abbcdbd

Mailaender force-pushed the infiltration-mission branch from 97d5368 to 080b00e Compare September 2, 2016 20:00

Mailaender removed the PR: Fixup requested label Sep 2, 2016

Mailaender force-pushed the infiltration-mission branch from 09c443a to 397d26c Compare September 3, 2016 05:22

obrakmann reviewed Sep 4, 2016
View reviewed changes

obrakmann added the PR: Fixup requested label Sep 4, 2016

Port the Co-Op Allies04 map to Lua.

76294c8

Mailaender force-pushed the infiltration-mission branch from 397d26c to 76294c8 Compare September 4, 2016 16:14

Mailaender removed the PR: Fixup requested label Sep 4, 2016

obrakmann merged commit a32a95a into OpenRA:bleed Sep 4, 2016

Mailaender deleted the infiltration-mission branch September 4, 2016 17:05

Mailaender mentioned this pull request Sep 8, 2016

Evacuating spies in Exodus mission crashes the game #11996

Closed

abcdefg30 mentioned this pull request Jun 22, 2017

LUA: make it possible to sell structures #9167

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Scott's Allies04 co-op multiplayer mission as "Infiltration" #11702

Added Scott's Allies04 co-op multiplayer mission as "Infiltration" #11702

Mailaender commented Jul 24, 2016 •

edited

Loading

pchote commented Jul 24, 2016

abcdefg30 Jul 24, 2016

Mailaender Jul 24, 2016

pchote Jul 24, 2016

pchote Jul 24, 2016

abcdefg30 commented Jul 24, 2016 •

edited

Loading

abcdefg30 commented Jul 24, 2016

abcdefg30 Jul 24, 2016

abcdefg30 Jul 24, 2016

Mailaender commented Jul 24, 2016

pchote Jul 24, 2016

Mailaender Jul 24, 2016 •

edited

Loading

obrakmann commented Aug 1, 2016

Mailaender commented Aug 1, 2016 •

edited

Loading

obrakmann commented Aug 3, 2016

obrakmann Aug 25, 2016

abcdefg30 Aug 27, 2016

pchote Aug 27, 2016

abcdefg30 Aug 27, 2016

obrakmann commented Aug 25, 2016

abcdefg30 commented Aug 27, 2016

abcdefg30 commented Aug 31, 2016

Mailaender commented Aug 31, 2016

abcdefg30 commented Aug 31, 2016

abcdefg30 commented Sep 2, 2016

Mailaender commented Sep 3, 2016

obrakmann Sep 4, 2016 •

edited

Loading

obrakmann commented Sep 4, 2016

Mailaender commented Sep 4, 2016

obrakmann commented Sep 4, 2016

Added Scott's Allies04 co-op multiplayer mission as "Infiltration" #11702

Added Scott's Allies04 co-op multiplayer mission as "Infiltration" #11702

Conversation

Mailaender commented Jul 24, 2016 • edited Loading

pchote commented Jul 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abcdefg30 commented Jul 24, 2016 • edited Loading

abcdefg30 commented Jul 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mailaender commented Jul 24, 2016

Choose a reason for hiding this comment

Mailaender Jul 24, 2016 • edited Loading

Choose a reason for hiding this comment

obrakmann commented Aug 1, 2016

Mailaender commented Aug 1, 2016 • edited Loading

obrakmann commented Aug 3, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

obrakmann commented Aug 25, 2016

abcdefg30 commented Aug 27, 2016

abcdefg30 commented Aug 31, 2016

Mailaender commented Aug 31, 2016

abcdefg30 commented Aug 31, 2016

abcdefg30 commented Sep 2, 2016

Mailaender commented Sep 3, 2016

obrakmann Sep 4, 2016 • edited Loading

Choose a reason for hiding this comment

obrakmann commented Sep 4, 2016

Mailaender commented Sep 4, 2016

obrakmann commented Sep 4, 2016

Mailaender commented Jul 24, 2016 •

edited

Loading

abcdefg30 commented Jul 24, 2016 •

edited

Loading

Mailaender Jul 24, 2016 •

edited

Loading

Mailaender commented Aug 1, 2016 •

edited

Loading

obrakmann Sep 4, 2016 •

edited

Loading