Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused SDL2-CS code paths #11782

Closed
wants to merge 1 commit into from

Conversation

Mailaender
Copy link
Member

The real change can be inspected at OpenRA/SDL2-CS#1. It shouldn't cause any changes except us shipping a slightly smaller DLL.

@Mailaender Mailaender added this to the Next release milestone Aug 7, 2016
@pchote
Copy link
Member

pchote commented Aug 7, 2016

We should use this chance to resync with upstream so that we get the SDL 2.0.4 bindings (wanted for #10382).

@Mailaender
Copy link
Member Author

Mailaender commented Aug 7, 2016

Upstream https://github.com/flibitijibibo/SDL2-CS doesn't implement GetDisplayDPI yet. https://github.com/flibitijibibo/SDL2-CS/search?utf8=%E2%9C%93&q=GetDisplayDPI You have to contribute a patch for a DLLImport yourself. Also: this is unrelated imho.

@pchote
Copy link
Member

pchote commented Aug 7, 2016

@Mailaender
Copy link
Member Author

Strange that GitHub code search didn't find it.

@Mailaender
Copy link
Member Author

I decided to go another route with this. #11793

@Mailaender Mailaender closed this Aug 9, 2016
@Mailaender Mailaender deleted the sdl2-cs-20160807 branch August 9, 2016 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants