Rework shellmap UX. #12465
Rework shellmap UX. #12465
Conversation
|
For some reason it doesn't work on the d2k shellmap, you can still hear sounds. The changes look correct, though. |
|
Works for me, so i'm not sure what to suggest. |
| @@ -84,6 +87,9 @@ public MusicPlaylist(World world, MusicPlaylistInfo info) | |||
| CurrentSongIsBackground = false; | |||
| } | |||
|
|
|||
| if (info.DisableWorldSounds) | |||
| Game.Sound.DisableWorldSounds = true; | |||
There was a problem hiding this comment.
It doesn't work in d2k for me and @obrakmann because we don't have any d2k music installed, so the return in line 62 prevents the code from ever getting here.
I guess you just need to move this check to the beginning of the constructor.
pchote
force-pushed
the
shellmap-overhaul
branch
from
5d6eb91
to
d055a45
Compare
|
Fixed. |
| @@ -103,7 +103,7 @@ public void DeployTransform(bool queued) | |||
| // Only play the "Cannot deploy here" audio | |||
| // for non-queued orders | |||
| foreach (var s in info.NoTransformSounds) | |||
| Game.Sound.PlayToPlayer(self.Owner, s); | |||
| Game.Sound.PlayToPlayer(SoundType.World, self.Owner, s); | |||
There was a problem hiding this comment.
This should be UI, I think.
There was a problem hiding this comment.
Nevermind, I just noticed the line below.
There was a problem hiding this comment.
Yep. The way these are used in the mods are a giant mess that needs to be rewritten. For now, i've assigned the type based on how they are used in the default mods (e.g. all the support power stuff plays UI sounds, most other things play world sounds).
There was a problem hiding this comment.
Notifications on UI and sounds for world always seemed like the intention to me, so I fail to see the giant mess. There are some cases where they mixture, like at crates though, but again those looks like legacy edge-cases to me..
There was a problem hiding this comment.
some → quite a few = mess.
pchote
force-pushed
the
shellmap-overhaul
branch
from
d055a45
to
0323692
Compare
|
Rebased. |
|
Um, what the hell? Why was this disabled again? |
|
We should still have an option to disable the shellmap. Maybe one with better code or whatever, but people should not be forced to have the shellmap playing. |
|
this forces every machine to run a quite ressource-hungry (even without sounds) background when waiting for a game to start ... we shouldnt have this option removed and i expect a bigger backlash here ... once the release is out here is difference on my AMD Athlon(tm) II P320 Dual-Core 2.10 ghz / ATI Radeon Mobile 5000 series (sound turned off) ... no need to say that it gets worse with time the longer the shellmap is running ... off on |
|
Can we have the option to disable the shellmap again please? As @Micr0Bit said, it is resource hungry (it actually seems worse now than it used to be!). I was in an RA lobby with American Blunt, who usually has good ping but was yellow due to the shellmap and complained of the inability to disable it. I too would usually disable it, primarily because of the sound, but also because of the needless resource usage and the distraction. |
|
@gdavegdave : for the current release , a blank-shellmap will help |
|
Thanks @Micr0Bit, that works. I've seen a couple of players asking about disabling the shell map (one in Global and one directly to me in Lobby, having seen this thread), so it does seem to be an issue for some. |
|
@dragunoff: Thank you for information. Is it complicated to implement a switch (shell map on/off) in the settings menu? |
This fixes a bunch of long-ignored annoyances with our shellmaps.
Mute the shellmap activity for all mods.
This one is a no-brainer that has been talked about for ages. This also disables the world sounds while the ingame menu is active, as suggested in #11355.
Closes #5619.
Closes #10700.
Closes #11355.
Closes #12299.
Remove the disable shellmap option.
I expect this will be a bit controversial, but the main reason for this toggle to exist was to mute the shellmap. Removing it cleans up the hacky code that implemented it, and puts an end to the bugs that keep on sneaking in for people with it disabled.
Closes #4966.
Closes #10762.
Replace the TD shellmap with the "shellmap disabled" background.
I expect this will also be quite controversial, but this is another case where a long-unfinished feature has sat rotting for years with no progress. IMO this background is more polished than the unfinished shellmap, and it serves as an example for modders who might want to do a more elaborate non-map menu background.
Closes #3016.
Closes #6943.