Fix timed external conditions being rejected instead of reset. #12625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phrohdoh
reviewed
Jan 25, 2017
| @@ -83,7 +83,7 @@ public void GrantTimedUpgrade(string upgrade, int duration) | |||
| public bool AcceptsUpgrade(string upgrade) | |||
| { | |||
| Game.Debug("AcceptsUpgrade is deprecated. Use AcceptsCondition instead."); | |||
| return AcceptsCondition(upgrade); | |||
| return AcceptsCondition(upgrade, false); | |||
There was a problem hiding this comment.
Why is this explicit false necessary?
There was a problem hiding this comment.
It isn't on this version of the commit. Removed.
pchote
force-pushed
the
fix-timed-conditions
branch
from
5d8c331
to
255214e
Compare
abcdefg30
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12498.