Replace "Debug" prefix with "Battlefield Control" for gameplay notifications. #12643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchote
force-pushed
the
battlefield-control
branch
2 times, most recently
from
be405bd
to
20a8ec8
Compare
pchote
changed the title
|
Added the other messages from #12387, which I had forgotten about. |
obrakmann
requested changes
Jan 29, 2017
| @@ -58,11 +62,13 @@ public void Tick(Actor self) | |||
|
|
|||
| public void OnPlayerLost(Player player) | |||
| { | |||
| Game.Debug("{0} is defeated.", player.PlayerName); | |||
| if (info.SuppressNotifications) | |||
| return; | |||
There was a problem hiding this comment.
You'll probably want to move that to below the foreach, otherwise it would be suppressing more than just the notifications.
There was a problem hiding this comment.
Could have sworn that i'd done that... anyway, fixed.
pchote
force-pushed
the
battlefield-control
branch
from
20a8ec8
to
e1f7e5d
Compare
obrakmann
approved these changes
Jan 29, 2017
chrisforbes
approved these changes
Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also introduces a
SuppressNotificationsflag that maps can use to disable the default messages if they want to display something different using Lua.