New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package loaders to mod code. #13347

Merged
merged 3 commits into from May 29, 2017

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented May 24, 2017

This is the final followup item from #13223.

This also marks a notable milestone: our core engine is now, except for the voxel loader, completely clean of format loaders or other algorithms used by the original games.

@pchote pchote changed the title from Move package loaders to Move package loaders to mod code. May 24, 2017

@rob-v

rob-v approved these changes May 28, 2017

👍
I am not sure how important it is to run some (and which) utility commands for test.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 May 29, 2017

Member

Needs a rebase.

Member

abcdefg30 commented May 29, 2017

Needs a rebase.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote May 29, 2017

Member

Rebased.

Member

pchote commented May 29, 2017

Rebased.

@pchote pchote removed the PR: Rebase me! label May 29, 2017

@abcdefg30 abcdefg30 merged commit 69587a2 into OpenRA:bleed May 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented May 29, 2017

@pchote pchote deleted the pchote:move-package-loaders branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment