New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition by unit stance #13389

Merged
merged 2 commits into from May 29, 2017

Conversation

Projects
None yet
2 participants
@atlimit8
Member

atlimit8 commented May 29, 2017

This was cherry-picked from an abandoned branch and then I added the MiniYAML fields from #13371 with IRulesetLoaded.RulesetLoaded for conversion. This is probably easier then suggesting the dictionary caching and actor passing instead of caching there since I had already written it.

@pchote

pchote approved these changes May 29, 2017

I prefer this to my approach in #13371, so 👍

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote May 29, 2017

Member

Carrying over the 👍's from @rob-v and @GraionDilach from #13371.

Member

pchote commented May 29, 2017

Carrying over the 👍's from @rob-v and @GraionDilach from #13371.

@pchote pchote merged commit afa5a77 into OpenRA:bleed May 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment