Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition by unit stance #13389

Merged
merged 2 commits into from
May 29, 2017
Merged

Condition by unit stance #13389

merged 2 commits into from
May 29, 2017

Conversation

atlimit8
Copy link
Member

@atlimit8 atlimit8 commented May 29, 2017

This was cherry-picked from an abandoned branch and then I added the MiniYAML fields from #13371 with IRulesetLoaded.RulesetLoaded for conversion. This is probably easier then suggesting the dictionary caching and actor passing instead of caching there since I had already written it.

Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this to my approach in #13371, so 👍

@pchote
Copy link
Member

pchote commented May 29, 2017

Carrying over the 👍's from @rob-v and @GraionDilach from #13371.

@pchote pchote merged commit afa5a77 into OpenRA:bleed May 29, 2017
@atlimit8 atlimit8 deleted the ConditionByUnitStance branch May 4, 2020 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants