New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chat tab to multiplayer/replays ingame menu #13408

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Projects
None yet
3 participants
@rob-v
Contributor

rob-v commented May 30, 2017

On game over this tab is opened by default so when game ends, this tab is activated and players can read and write before leaving. The chat tab is hidden in case there is only one human player.

obrazok

Edit: In the chat tab are also replayed older messages for which we don't store time atm so we could show the time only for new messages so I removed the time for now. If agreed, we could extend chat cache to store also time (sent or received?) and then display it here and/or also in game chat.

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v Jul 31, 2017

Contributor

to free PR queue.

Contributor

rob-v commented Jul 31, 2017

to free PR queue.

@rob-v rob-v closed this Jul 31, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jul 31, 2017

Member

I would really like this for next + 1. Can you reopen it? Or are you abandoning the feature completely?

Member

pchote commented Jul 31, 2017

I would really like this for next + 1. Can you reopen it? Or are you abandoning the feature completely?

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v Jul 31, 2017

Contributor

Ok, looked like no interest in this one.

Contributor

rob-v commented Jul 31, 2017

Ok, looked like no interest in this one.

@rob-v rob-v reopened this Jul 31, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jul 31, 2017

Member

Interest, but not time

Member

pchote commented Jul 31, 2017

Interest, but not time

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v Aug 1, 2017

Contributor

Updated.

Contributor

rob-v commented Aug 1, 2017

Updated.

@pchote

Looks good overall, just two points that I think need more discussion before merging:

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v Aug 17, 2017

Contributor

Updated.

Contributor

rob-v commented Aug 17, 2017

Updated.

@pchote

pchote approved these changes Aug 17, 2017

@pchote pchote merged commit c848b30 into OpenRA:bleed Aug 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment