New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom hit-shapes and TargetableOffsets to RA structures #13448
Conversation
Currently contains the code changes from #13196, so one of them will need a rebase (probably this one). |
mods/ra/rules/defaults.yaml
Outdated
@@ -491,6 +491,8 @@ | |||
Inherits@1: ^ExistsInWorld | |||
Inherits@2: ^IronCurtainable | |||
Inherits@3: ^SpriteActor | |||
BodyOrientation: | |||
CameraPitch: 255 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the shape of armament muzzles as they rotate with facing. This was previously tuned to look correct, so I am assuming that this will break that. Unless this was specifically to fix that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This regresses at least the turret firing offsets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about the defenses when setting this, but it's easy to fix as all defenses use footprint offsets and therefore don't really need the 'top-down' pitch.
Some of the targetable postions (e.g. powr, both barracks, airfields) are floating outside the building artwork. Would you mind doing some tweaks to put them inside? |
Well, it's a bit tedious, but I guess better to do it now than needing another follow-up PR. |
Rebased and updated. Travis didn't trigger, but it passed |
And do some cleanup. Intentionally omitted uncommon shapes that only appear once or twice.
Needs a rebase |
Rebased. |
Fixed in #13475 to avoid cluttering this PR. |
To make sure they play on top of actors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
In one of the followup balance PRs I think we should add |
That will need another partial Attack*/Armament/projectiles rewrite, just sayin'. |
RA equivalent to #13196.