New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom hit-shapes and TargetableOffsets to RA structures #13448

Merged
merged 4 commits into from Jun 10, 2017

Conversation

Projects
None yet
3 participants
@reaperrr
Contributor

reaperrr commented Jun 4, 2017

RA equivalent to #13196.

@reaperrr reaperrr added this to the Playtest featuring updated HitShapes milestone Jun 4, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 4, 2017

Contributor

Currently contains the code changes from #13196, so one of them will need a rebase (probably this one).

Contributor

reaperrr commented Jun 4, 2017

Currently contains the code changes from #13196, so one of them will need a rebase (probably this one).

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 4, 2017

Member

Some of the targetable postions (e.g. powr, both barracks, airfields) are floating outside the building artwork. Would you mind doing some tweaks to put them inside?

Member

pchote commented Jun 4, 2017

Some of the targetable postions (e.g. powr, both barracks, airfields) are floating outside the building artwork. Would you mind doing some tweaks to put them inside?

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 4, 2017

Contributor

Some of the targetable postions (e.g. powr, both barracks, airfields) are floating outside the building artwork. Would you mind doing some tweaks to put them inside?

Well, it's a bit tedious, but I guess better to do it now than needing another follow-up PR.

Contributor

reaperrr commented Jun 4, 2017

Some of the targetable postions (e.g. powr, both barracks, airfields) are floating outside the building artwork. Would you mind doing some tweaks to put them inside?

Well, it's a bit tedious, but I guess better to do it now than needing another follow-up PR.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 5, 2017

Contributor

Rebased and updated. Travis didn't trigger, but it passed make test locally and no longer contains code, so it shouldn't matter.

Contributor

reaperrr commented Jun 5, 2017

Rebased and updated. Travis didn't trigger, but it passed make test locally and no longer contains code, so it shouldn't matter.

@reaperrr reaperrr changed the title from Add custom hit-shapes to RA buildings to Add custom hit-shapes and TargetableOffsets to RA structures Jun 5, 2017

Add building hitshape defaults to RA
And do some cleanup.
Intentionally omitted uncommon shapes that only appear once or twice.
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 6, 2017

Member

Needs a rebase

Member

pchote commented Jun 6, 2017

Needs a rebase

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 6, 2017

Contributor

Rebased.
And updated with explosion ZOffset increase.

Contributor

reaperrr commented Jun 6, 2017

Rebased.
And updated with explosion ZOffset increase.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jun 7, 2017

Member

Tesla weaponary still target the center of actor, not closest target. I tested with Shock Trooper and Tesla Coil.

adsiz

Sov Tech Center, Radar Dome, Techology Center and Tech Oil Derrick also looks like they want some adjusments of Target Positions according to artwork.

oild

techno

Member

MustaphaTR commented Jun 7, 2017

Tesla weaponary still target the center of actor, not closest target. I tested with Shock Trooper and Tesla Coil.

adsiz

Sov Tech Center, Radar Dome, Techology Center and Tech Oil Derrick also looks like they want some adjusments of Target Positions according to artwork.

oild

techno

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 7, 2017

Contributor

Tesla weaponary still target the center of actor, not closest target. I tested with Shock Trooper and Tesla Coil.

Fixed in #13475 to avoid cluttering this PR.

Contributor

reaperrr commented Jun 7, 2017

Tesla weaponary still target the center of actor, not closest target. I tested with Shock Trooper and Tesla Coil.

Fixed in #13475 to avoid cluttering this PR.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 7, 2017

Contributor

Updated:

new-t-pos

Contributor

reaperrr commented Jun 7, 2017

Updated:

new-t-pos

@MustaphaTR

👍

@pchote

pchote approved these changes Jun 10, 2017

@pchote pchote merged commit 16e260e into OpenRA:bleed Jun 10, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 10, 2017

Member

In one of the followup balance PRs I think we should add TargetCenterPosition: true to artillery and cruisers. It looks rather odd for them to try and aim at the corner of a building when their inaccuraccy is comparable to the building size.

Member

pchote commented Jun 10, 2017

In one of the followup balance PRs I think we should add TargetCenterPosition: true to artillery and cruisers. It looks rather odd for them to try and aim at the corner of a building when their inaccuraccy is comparable to the building size.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 11, 2017

Contributor

In one of the followup balance PRs I think we should add TargetCenterPosition: true to artillery and cruisers.

That will need another partial Attack*/Armament/projectiles rewrite, just sayin'.

Contributor

reaperrr commented Jun 11, 2017

In one of the followup balance PRs I think we should add TargetCenterPosition: true to artillery and cruisers.

That will need another partial Attack*/Armament/projectiles rewrite, just sayin'.

@reaperrr reaperrr deleted the reaperrr:RA-hitshapes1 branch Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment