Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom hit-shapes and TargetableOffsets to RA structures #13448

Merged
merged 4 commits into from Jun 10, 2017

Conversation

reaperrr
Copy link
Contributor

@reaperrr reaperrr commented Jun 4, 2017

RA equivalent to #13196.

@reaperrr reaperrr added this to the Playtest featuring updated HitShapes milestone Jun 4, 2017
@reaperrr
Copy link
Contributor Author

reaperrr commented Jun 4, 2017

Currently contains the code changes from #13196, so one of them will need a rebase (probably this one).

@@ -491,6 +491,8 @@
Inherits@1: ^ExistsInWorld
Inherits@2: ^IronCurtainable
Inherits@3: ^SpriteActor
BodyOrientation:
CameraPitch: 255
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the shape of armament muzzles as they rotate with facing. This was previously tuned to look correct, so I am assuming that this will break that. Unless this was specifically to fix that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This regresses at least the turret firing offsets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about the defenses when setting this, but it's easy to fix as all defenses use footprint offsets and therefore don't really need the 'top-down' pitch.

@pchote
Copy link
Member

pchote commented Jun 4, 2017

Some of the targetable postions (e.g. powr, both barracks, airfields) are floating outside the building artwork. Would you mind doing some tweaks to put them inside?

@reaperrr
Copy link
Contributor Author

reaperrr commented Jun 4, 2017

Some of the targetable postions (e.g. powr, both barracks, airfields) are floating outside the building artwork. Would you mind doing some tweaks to put them inside?

Well, it's a bit tedious, but I guess better to do it now than needing another follow-up PR.

@reaperrr
Copy link
Contributor Author

reaperrr commented Jun 5, 2017

Rebased and updated. Travis didn't trigger, but it passed make test locally and no longer contains code, so it shouldn't matter.

@reaperrr reaperrr changed the title Add custom hit-shapes to RA buildings Add custom hit-shapes and TargetableOffsets to RA structures Jun 5, 2017
And do some cleanup.
Intentionally omitted uncommon shapes that only appear once or twice.
@pchote
Copy link
Member

pchote commented Jun 6, 2017

Needs a rebase

@reaperrr
Copy link
Contributor Author

reaperrr commented Jun 6, 2017

Rebased.
And updated with explosion ZOffset increase.

@MustaphaTR
Copy link
Member

MustaphaTR commented Jun 7, 2017

Tesla weaponary still target the center of actor, not closest target. I tested with Shock Trooper and Tesla Coil.

adsiz

Sov Tech Center, Radar Dome, Techology Center and Tech Oil Derrick also looks like they want some adjusments of Target Positions according to artwork.

oild

techno

@reaperrr
Copy link
Contributor Author

reaperrr commented Jun 7, 2017

Tesla weaponary still target the center of actor, not closest target. I tested with Shock Trooper and Tesla Coil.

Fixed in #13475 to avoid cluttering this PR.

@reaperrr
Copy link
Contributor Author

reaperrr commented Jun 7, 2017

Updated:

new-t-pos

Copy link
Member

@MustaphaTR MustaphaTR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pchote pchote merged commit 16e260e into OpenRA:bleed Jun 10, 2017
@pchote
Copy link
Member

pchote commented Jun 10, 2017

In one of the followup balance PRs I think we should add TargetCenterPosition: true to artillery and cruisers. It looks rather odd for them to try and aim at the corner of a building when their inaccuraccy is comparable to the building size.

@reaperrr
Copy link
Contributor Author

In one of the followup balance PRs I think we should add TargetCenterPosition: true to artillery and cruisers.

That will need another partial Attack*/Armament/projectiles rewrite, just sayin'.

@reaperrr reaperrr deleted the RA-hitshapes1 branch July 23, 2017 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants