Attack dog leap improvement #13513

forcecore · 2017-06-15T16:00:36Z

Attempt to fix #7506

Based on Mailaender's dog improvement PR #11715. (Sorry about C&P instead of Git Cherry Pick but it was way behind bleed)

Demo:

https://www.youtube.com/watch?v=GLGbeL4F-fg : unhardcoded 1-shot kill
https://www.youtube.com/watch?v=BS7e8b99L-w : Dog fight (no more indefinite jump loop)
https://www.youtube.com/watch?v=eKaIIwWaye0 : vs Riflemen

pchote · 2017-06-15T17:40:40Z

OpenRA.Mods.Cnc/Activities/LeapAttack.cs

+
+			var leapToken = ConditionManager.InvalidConditionToken;
+
+			return ActivityUtils.SequenceActivities(


Please use child activities and OnFirstRun instead of SequenceActivities. Refer to the Transform activity for an example.

forcecore · 2017-06-16T01:48:22Z

Now using parent-child activity
Buff on and off now encapsulated in AttackLeap class.
Leap stuff shouldn't be pre-calculated in OnFirstRun otherwise it will be incorrect, as self can change position.

forcecore · 2017-06-18T13:53:06Z

Forgot to mention, in parent-child activity version, I addressed far-jumping dogs
https://youtu.be/1lGmjOaNBxQ

forcecore · 2017-06-18T13:58:21Z

Fixed shell map crash that wasn't caught before

reaperrr · 2017-07-21T21:06:58Z

Needs rebase.

forcecore · 2017-07-26T00:22:42Z

Rebased

atlimit8 · 2017-07-26T04:11:30Z

OpenRA.Mods.Cnc/Activities/Leap.cs

 	}
-}
+}


nit: Leave newline here.

atlimit8 · 2017-07-26T04:13:52Z

OpenRA.Mods.Common/Traits/Conditions/GrantConditionOnAttack.cs

+				conditionManager.GrantCondition(self, info.AttackingCondition, info.AttackingDuration);
+		}
+	}
+}


forcecore · 2017-07-27T03:54:48Z

EOL fixed, squashed.

atlimit8

TheCallFunc activity is not serialization friendly (game saving). Granted, it may take a while before that can be added; however, it is better to code for its support now than to make more work for later.

atlimit8 · 2017-07-27T19:33:39Z

OpenRA.Mods.Cnc/Activities/LeapAttack.cs

+			{
+				attack.ApproachBuffOn(self);
+				QueueChild(new MoveWithinRange(self, target, WDist.Zero, range));
+				QueueChild(new CallFunc(() => attack.ApproachBuffOff(self)));


Remove:

QueueChild(new CallFunc(() => attack.ApproachBuffOff(self)));

atlimit8 · 2017-07-27T19:33:46Z

OpenRA.Mods.Cnc/Activities/LeapAttack.cs

+			var range = attack.GetMaximumRange();
+			if (!target.IsInRange(self.CenterPosition, range))
+			{
+				attack.ApproachBuffOn(self);


Append:

isApproachBuffOn = true;

atlimit8 · 2017-07-27T19:48:01Z

OpenRA.Mods.Cnc/Activities/LeapAttack.cs

+
+			if (ChildActivity != null)
+			{
+				ActivityUtils.RunActivity(self, ChildActivity);


Replace with:

var act = ActivityUtils.RunActivity(self, ChildActivity); if (isApproachBuffOn && act == this)) attack.ApproachBuffOff(self);

atlimit8 · 2017-07-27T19:48:42Z

OpenRA.Mods.Cnc/Activities/LeapAttack.cs

+		readonly Target target;
+		readonly AttackLeapInfo info;
+		readonly Mobile mobile;
+		readonly AttackLeap attack;


Append:

bool isApproachBuffOn = false;

…nc removal

forcecore · 2017-08-01T04:26:37Z

Removed CallFunc. Removed more visual glitch.

AttackLeap:
	Voice: Attack
	LeapCondition: leap
	ApproachCondition: rush
	# Disable another leap while leaping or ripping
	RequiresCondition: !leap && !rip

I also made rip condition to disable AttackLeap to prevent dogs from jumping immediately. The problem is, if I queue attack orders, rip disables the attack trait and the queue gets canceled. I didn't look into detail on the reason but I can't queue anymore with && !rip condition. If I remove && !rip things return to normal. I think AttackBase trait should be a pausable trait as well.

pchote · 2017-08-17T17:00:17Z

I think AttackBase trait should be a pausable trait as well.

This sounds like a sensible solution. Would you mind filing a PR for this?

pchote · 2017-08-17T17:07:49Z

This reintroduces problems with dogs stacking on top of other infantry.

Repro case:

Start a game with two clients
Player one builds a cell full of non-combat infantry, or normal infantry in the hold fire stance
Player two builds 5 dogs, puts them in the hold fire stance, and orders them to move next to player 1's units.
Player two selects all 5 dogs and orders them to attack the center unit from Player one's cell.

The dogs will then leap but not adjust their sub-cells. The outer 4 will be left overlapping with Player one's other infantry:

GraionDilach · 2017-08-17T17:23:31Z

I'd like to see this trait renamed to AttackJoust during this PR, because it no longer involves a leap.

See my reasoning at OpenRA/ra2#328 (comment).

forcecore · 2017-08-18T00:25:09Z

I let them overlap. Otherwise, when the cell contains 5 enemy infantries, attack dogs can't attack any of those infantries at all. If I don't hard-code one-shot kill into the code, I'd get overlap anyway if target HP > dog damage. The neatest solution without unit stacking would be to implement RA3 dog/bear melee attack.

Now I see why WW hard coded one-shot-kill to RA2 attack dogs.

forcecore · 2017-08-18T04:56:05Z

I think AttackBase trait should be a pausable trait as well.
This sounds like a sensible solution. Would you mind filing a PR for this?

I'll try. That should improve EMP in TS too.

pchote · 2017-08-18T08:28:21Z

If I don't hard-code one-shot kill into the code, I'd get overlap anyway if target HP > dog damage.

This is precisely the reason for the one-shot kill in the current implementation.

forcecore · 2017-08-21T20:17:32Z

I inteded to respect Mailaender's removal of one shot kill. I guess I have to bring back it back. On the other hand, if dogs jump at the same time to the same target, they will overlap. I think the proper way to avoid this is to introduce some kind of a coordination to the jumping, something like resource claim layer. What do you think about the doggy jumping coordination layer?

GraionDilach · 2017-08-21T21:02:50Z

Hardcoding the one-shot-kill will remove the chance of using this implementation for parasite behaviour (RA2 Terror Drone vs vehicles, Firestorm Limpet Drone). Another option would be that the actor would bounce to a free subcell after an attack when the target isn't killed.

forcecore · 2017-08-22T22:40:05Z

Hmm, probably why the attack dogs in RA1 "slides" after ripping up. I'll try that.

pchote · 2017-08-25T22:15:25Z

I think the proper way to avoid this is to introduce some kind of a coordination to the jumping, something like resource claim layer. What do you think about the doggy jumping coordination layer?

Yes, we need this, but not as a layer. Implement it as a trait on the actor itself, like we have for external capturing or the various things that lock buildings.

pchote · 2017-08-25T22:16:56Z

Hardcoding the one-shot-kill will remove the chance of using this implementation for parasite behaviour

Parasite behaviour requires the targeting actor to enter the target, which is a completely different usecase. Trying to solve that with the same code as attack dogs makes for uglier and more complicated solutions than necessary for both.

GraionDilach · 2017-09-06T16:05:53Z

Squid parasite didn't really entered into the target, was moreso attached to.

pchote · 2017-09-06T16:08:21Z

Squid parasite behaviour requires the targeting actor to attach to the target, which is a completely different usecase. Trying to solve that with the same code as attack dogs makes for uglier and more complicated solutions than necessary for both.

😉

pchote · 2017-09-24T12:18:01Z

@forcecore: do you plan on continuing with this in the short term?

forcecore · 2017-09-24T12:43:38Z

Not in the short term, I have personal issues to sort out for about a few weeks.

pchote · 2017-09-24T12:46:38Z

Ok, no worries. I've moved this to the Future milestone so that we don't lose track of this, and will close it for now to help reduce the PR queue to items that need active review. Please do reopen this as soon as you are able to continue, because it would be good to finally fix this.

forcecore force-pushed the doggiefix branch from 2620b30 to f1503b2 Compare June 15, 2017 17:32

pchote reviewed Jun 15, 2017

View reviewed changes

forcecore force-pushed the doggiefix branch from c5ac267 to 4aa63c0 Compare June 16, 2017 01:34

reaperrr added this to the Next release milestone Jun 25, 2017

SoScared mentioned this pull request Jul 14, 2017

[RA] Visual, Polish/Performance and Balance Tweak for the next Playtest #13640

Merged

reaperrr added the PR: Rebase me! label Jul 21, 2017

forcecore force-pushed the doggiefix branch from 65d4387 to 1f1e093 Compare July 26, 2017 00:22

atlimit8 removed the PR: Rebase me! label Jul 26, 2017

atlimit8 reviewed Jul 26, 2017

View reviewed changes

OpenRA.Mods.Cnc/Activities/Leap.cs Outdated

}

}

}

Copy link

Member

atlimit8 Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Leave newline here.

atlimit8 reviewed Jul 26, 2017

View reviewed changes

Attack dog leap improvement

681531b

forcecore force-pushed the doggiefix branch from 1f1e093 to 681531b Compare July 27, 2017 03:54

atlimit8 reviewed Jul 27, 2017

View reviewed changes

(to be squashed) YAML update for bleed, visual glitch removal, CallFu…

b6b41ea

…nc removal

forcecore force-pushed the doggiefix branch from 2c7ed47 to b6b41ea Compare August 1, 2017 04:21

More simplification

b968567

pchote added the PR: Changes requested label Aug 17, 2017

abcdefg30 added the PR: Rebase me! label Sep 13, 2017

pchote mentioned this pull request Sep 24, 2017

Improved the Red Alert dog behavior #11715

Closed

pchote modified the milestones: Next + 1, Future Sep 24, 2017

pchote closed this Sep 24, 2017

abcdefg30 mentioned this pull request Mar 30, 2018

Rewrite Leap and AttackLeap, add LeapAttack and EdibleByAttackLeap #15008

Merged

abcdefg30 removed this from the Future milestone Mar 30, 2018

forcecore deleted the doggiefix branch January 23, 2021 12:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attack dog leap improvement #13513

Attack dog leap improvement #13513

forcecore commented Jun 15, 2017 •

edited

Loading

pchote Jun 15, 2017

forcecore commented Jun 16, 2017

forcecore commented Jun 18, 2017

forcecore commented Jun 18, 2017

reaperrr commented Jul 21, 2017

forcecore commented Jul 26, 2017

atlimit8 Jul 26, 2017

atlimit8 Jul 26, 2017

forcecore commented Jul 27, 2017

atlimit8 left a comment •

edited

Loading

atlimit8 Jul 27, 2017

atlimit8 Jul 27, 2017

atlimit8 Jul 27, 2017

atlimit8 Jul 27, 2017

forcecore commented Aug 1, 2017 •

edited

Loading

pchote commented Aug 17, 2017

pchote commented Aug 17, 2017

GraionDilach commented Aug 17, 2017

forcecore commented Aug 18, 2017 •

edited

Loading

forcecore commented Aug 18, 2017

pchote commented Aug 18, 2017 •

edited

Loading

forcecore commented Aug 21, 2017

GraionDilach commented Aug 21, 2017

forcecore commented Aug 22, 2017

pchote commented Aug 25, 2017

pchote commented Aug 25, 2017

GraionDilach commented Sep 6, 2017

pchote commented Sep 6, 2017

pchote commented Sep 24, 2017

forcecore commented Sep 24, 2017

pchote commented Sep 24, 2017 •

edited

Loading


		var leapToken = ConditionManager.InvalidConditionToken;

		return ActivityUtils.SequenceActivities(

Attack dog leap improvement #13513

Attack dog leap improvement #13513

Conversation

forcecore commented Jun 15, 2017 • edited Loading

pchote Jun 15, 2017

Choose a reason for hiding this comment

forcecore commented Jun 16, 2017

forcecore commented Jun 18, 2017

forcecore commented Jun 18, 2017

reaperrr commented Jul 21, 2017

forcecore commented Jul 26, 2017

atlimit8 Jul 26, 2017

Choose a reason for hiding this comment

atlimit8 Jul 26, 2017

Choose a reason for hiding this comment

forcecore commented Jul 27, 2017

atlimit8 left a comment • edited Loading

Choose a reason for hiding this comment

atlimit8 Jul 27, 2017

Choose a reason for hiding this comment

atlimit8 Jul 27, 2017

Choose a reason for hiding this comment

atlimit8 Jul 27, 2017

Choose a reason for hiding this comment

atlimit8 Jul 27, 2017

Choose a reason for hiding this comment

forcecore commented Aug 1, 2017 • edited Loading

pchote commented Aug 17, 2017

pchote commented Aug 17, 2017

GraionDilach commented Aug 17, 2017

forcecore commented Aug 18, 2017 • edited Loading

forcecore commented Aug 18, 2017

pchote commented Aug 18, 2017 • edited Loading

forcecore commented Aug 21, 2017

GraionDilach commented Aug 21, 2017

forcecore commented Aug 22, 2017

pchote commented Aug 25, 2017

pchote commented Aug 25, 2017

GraionDilach commented Sep 6, 2017

pchote commented Sep 6, 2017

pchote commented Sep 24, 2017

forcecore commented Sep 24, 2017

pchote commented Sep 24, 2017 • edited Loading

forcecore commented Jun 15, 2017 •

edited

Loading

atlimit8 left a comment •

edited

Loading

forcecore commented Aug 1, 2017 •

edited

Loading

forcecore commented Aug 18, 2017 •

edited

Loading

pchote commented Aug 18, 2017 •

edited

Loading

pchote commented Sep 24, 2017 •

edited

Loading