Allow turning Missile terrain height checks off #13628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know we've been scope-creeping the playtest a lot already so I won't insist on it, but for all mods without height levels - including our shipping mods - the savings in large battles can be rather significant, so if we can get this reviewed and mergable fast enough, I think it should go in. If the playtest turns up any regressions that were overlooked during review, we can still revert it in time for the release. |
abcdefg30
approved these changes
Jul 13, 2017
|
Needs a rebase. |
This saves a good deal of performance for mods with no real height levels, including RA, TD and D2k.
reaperrr
force-pushed
the
MissileTerrainToggle
branch
from
310e751
to
4458388
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And do so by default.
At second glance this was easier than expected, by just preventing all height-related helpers from triggering if
!TerrainHeightAware.Couldn't spot any regressions so far.
Closes #13616.
Debug builds on my system (Win7x64, i5-2500 @ 3.2GHz) show ~0.015ms savings per Dragon missile in RA.