New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turning Missile terrain height checks off #13628

Merged
merged 2 commits into from Jul 15, 2017

Conversation

Projects
None yet
3 participants
@reaperrr
Contributor

reaperrr commented Jul 13, 2017

And do so by default.

At second glance this was easier than expected, by just preventing all height-related helpers from triggering if !TerrainHeightAware.
Couldn't spot any regressions so far.

Closes #13616.

Debug builds on my system (Win7x64, i5-2500 @ 3.2GHz) show ~0.015ms savings per Dragon missile in RA.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 13, 2017

Contributor

I know we've been scope-creeping the playtest a lot already so I won't insist on it, but for all mods without height levels - including our shipping mods - the savings in large battles can be rather significant, so if we can get this reviewed and mergable fast enough, I think it should go in. If the playtest turns up any regressions that were overlooked during review, we can still revert it in time for the release.

Contributor

reaperrr commented Jul 13, 2017

I know we've been scope-creeping the playtest a lot already so I won't insist on it, but for all mods without height levels - including our shipping mods - the savings in large battles can be rather significant, so if we can get this reviewed and mergable fast enough, I think it should go in. If the playtest turns up any regressions that were overlooked during review, we can still revert it in time for the release.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Jul 15, 2017

Member

Needs a rebase.

Member

abcdefg30 commented Jul 15, 2017

Needs a rebase.

reaperrr added some commits Jul 13, 2017

Allow disabling terrain height checks in Missile
This saves a good deal of performance for mods with no real height levels, including RA, TD and D2k.
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 15, 2017

Contributor

Rebased.

Contributor

reaperrr commented Jul 15, 2017

Rebased.

@GraionDilach

LGTM then.

@reaperrr reaperrr merged commit ace353c into OpenRA:bleed Jul 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reaperrr reaperrr deleted the reaperrr:MissileTerrainToggle branch Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment