New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AI BuildingLimits #14025

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Projects
None yet
3 participants
@reaperrr
Contributor

reaperrr commented Sep 15, 2017

The AI BaseBuilder would allow building a structure not only when the current number was lower, but also if it was equal to the limit, which allowed the AI to build one too many of every building with a build limit.

This is a simple and obvious enough fix to sneak into stable.

Closes #11917.

@reaperrr reaperrr added this to the Next Release milestone Sep 15, 2017

Fix AI BuildingLimits
The AI BaseBuilder would allow building a structure not only when the current number was lower, but also of it was equal to the limit, which allowed the AI to build one too much of every building.
@RoosterDragon

👍

@pchote

pchote approved these changes Sep 15, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Sep 15, 2017

Member

The fix looks sensible enough, but I think that it is too risky for prep: this is potentially a major change to the AI balance, so needs longer to bake than the last playtest before a release!

Member

pchote commented Sep 15, 2017

The fix looks sensible enough, but I think that it is too risky for prep: this is potentially a major change to the AI balance, so needs longer to bake than the last playtest before a release!

@pchote pchote merged commit 08aaa99 into OpenRA:bleed Sep 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote removed the PR: For stable label Sep 15, 2017

@pchote pchote removed this from the Next Release milestone Sep 15, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Sep 15, 2017

Contributor

The fix looks sensible enough, but I think that it is too risky for prep: this is potentially a major change to the AI balance, so needs longer to bake than the last playtest before a release!

Fair enough.

Contributor

reaperrr commented Sep 15, 2017

The fix looks sensible enough, but I think that it is too risky for prep: this is potentially a major change to the AI balance, so needs longer to bake than the last playtest before a release!

Fair enough.

@reaperrr reaperrr deleted the reaperrr:fix-AI-BuidlLimit branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment