TryGetValue is now being used when getting WeaponInfo instances #14111
Conversation
OpenRA.Mods.Cnc/Traits/MadTank.cs
Outdated
| DetonationWeaponInfo = rules.Weapons[DetonationWeapon.ToLowerInvariant()]; | ||
| WeaponInfo thumpDamageWeapon; | ||
| WeaponInfo detonationWeapon; | ||
| var thumpDmgWeapToLower = ThumpDamageWeapon.ToLowerInvariant(); |
There was a problem hiding this comment.
Style nit: avoid removing arbitrary letters from variable names. Saving 5 characters on a throwaway local variable isn't worth the hit to readability. thumpDamageWeaponToLower and detonationWeaponToLower are fine. If you really want to use shorter names then thumpName and detonationName would also be fine considering the context.
There was a problem hiding this comment.
I suggest using (ThumpDamageWeapon ?? string.Empty).ToLowerInvariant() here and in the other cases where the weapons aren't optional to avoid a NullReferenceException if the mod yaml overrides it to be empty (which translates to a null value).
|
Can you please also squash the commits once you're done? |
SirJson
force-pushed
the
trygetvalue-weaponinfo-instances
branch
from
e010dd5
to
532d0fa
Compare
….Weapons Removed invalid spacing at the end of the line 36 in ThrowsShrapnel Prevented NullReferenceException in cases where weapons aren't optional
SirJson
force-pushed
the
trygetvalue-weaponinfo-instances
branch
from
532d0fa
to
459ae19
Compare
|
Fixed up everything and squashed my commits. I'm using now the more verbose variant for the local variables for more consistency with the rest of the code. |
A YamlException is thrown if TryGetValue fails. Closes #13692.