New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TryGetValue is now being used when getting WeaponInfo instances #14111

Merged
merged 1 commit into from Oct 14, 2017

Conversation

Projects
None yet
4 participants
@SirJson
Contributor

SirJson commented Oct 3, 2017

A YamlException is thrown if TryGetValue fails. Closes #13692.

@pchote

Looks good overall. Just a couple of small requests:

Show outdated Hide outdated OpenRA.Mods.Cnc/Traits/MadTank.cs Outdated
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Oct 8, 2017

Member

Can you please also squash the commits once you're done?

Member

pchote commented Oct 8, 2017

Can you please also squash the commits once you're done?

YamlException is now thrown if WeaponInfo can not be found in Ruleset…
….Weapons

Removed invalid spacing at the end of the line 36 in ThrowsShrapnel

Prevented NullReferenceException in cases where weapons aren't optional
@SirJson

This comment has been minimized.

Show comment
Hide comment
@SirJson

SirJson Oct 9, 2017

Contributor

Fixed up everything and squashed my commits. I'm using now the more verbose variant for the local variables for more consistency with the rest of the code.

Contributor

SirJson commented Oct 9, 2017

Fixed up everything and squashed my commits. I'm using now the more verbose variant for the local variables for more consistency with the rest of the code.

@pchote

pchote approved these changes Oct 14, 2017

@pchote pchote added the PR: Needs +2 label Oct 14, 2017

@reaperrr reaperrr merged commit f2b5040 into OpenRA:bleed Oct 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Oct 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment