New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Harkonnen 6b #14288

Merged
merged 1 commit into from Nov 19, 2017

Conversation

Projects
None yet
6 participants
@MustaphaTR
Member

MustaphaTR commented Nov 3, 2017

No description provided.

@penev92 penev92 referenced this pull request Nov 3, 2017

Open

Add Dune 2000 campaign #9287

@ltem

The mission plays like the original. Only the Smugglers will become your enemies if you attack their units (message pops up (see image)) but they won't send units against you. I've overlooked this in Harkonnen06a but it doesn't really change the gameplay and I think this isn't possible in OpenRA for now.
Edit1: I don't know how but learned it is possible to do in Lua, so maybe this can be added (later).

harkonnen6b_smugglershostile

After this is I'll approve this PR.

Show outdated Hide outdated mods/d2k/maps/harkonnen-06b/harkonnen06b.lua Outdated
@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 11, 2017

Member

I intentedly left out Smuggler side changing, in 6a too. It is not really important and lack of alliance changes make it unnecessarily complicated.

RA and TD mods campaign missions use Enemy Unit/Structure and no owner name. I'm planning to add that to D2K too, probably when Har Missions are all added. Maybe i add Smuggler Owner changes with it too.

Member

MustaphaTR commented Nov 11, 2017

I intentedly left out Smuggler side changing, in 6a too. It is not really important and lack of alliance changes make it unnecessarily complicated.

RA and TD mods campaign missions use Enemy Unit/Structure and no owner name. I'm planning to add that to D2K too, probably when Har Missions are all added. Maybe i add Smuggler Owner changes with it too.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 11, 2017

Member

Smugglers can be made hostile by setting up a second faction with different allies/enemies and switching all the actors over using lua.

Member

pchote commented Nov 11, 2017

Smugglers can be made hostile by setting up a second faction with different allies/enemies and switching all the actors over using lua.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Nov 11, 2017

Contributor

Okay, I'm fine with that.

Contributor

ltem commented Nov 11, 2017

Okay, I'm fine with that.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Nov 12, 2017

Member

Smugglers can be made hostile by setting up a second faction with different allies/enemies and switching all the actors over using lua.

Imho that is what should be done to retain the " Smugglers will become your enemies if you attack their units".

Edit: As requested by @penev92: Don't forget to remove the interval (#14288 (comment)) as well. ^^

Member

abcdefg30 commented Nov 12, 2017

Smugglers can be made hostile by setting up a second faction with different allies/enemies and switching all the actors over using lua.

Imho that is what should be done to retain the " Smugglers will become your enemies if you attack their units".

Edit: As requested by @penev92: Don't forget to remove the interval (#14288 (comment)) as well. ^^

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 18, 2017

Member

Updated, added the Smuggler Owner/Stance change to both 6th missions, but still a bit different than original. You can't normally target the Smuggler units, but if you force fire on them or hit them by mistake, they turn against you.

Also Ordos may mistakely hit them and they can be enemy to ordos, without being an enemy to you. I remember that being case in the original, but not 100% sure. It makes more sense this way tho.

I made Smugglers non-combatant so their owner row won't be shown. I'll get rid of Owner Rows/Use Generic names with a future PR after getting all Harkonnen Missions merged, like other mods does anyway.

Member

MustaphaTR commented Nov 18, 2017

Updated, added the Smuggler Owner/Stance change to both 6th missions, but still a bit different than original. You can't normally target the Smuggler units, but if you force fire on them or hit them by mistake, they turn against you.

Also Ordos may mistakely hit them and they can be enemy to ordos, without being an enemy to you. I remember that being case in the original, but not 100% sure. It makes more sense this way tho.

I made Smugglers non-combatant so their owner row won't be shown. I'll get rid of Owner Rows/Use Generic names with a future PR after getting all Harkonnen Missions merged, like other mods does anyway.

@ltem

ltem approved these changes Nov 18, 2017

Requests fixed and no more issues found.

@reaperrr reaperrr merged commit 7b12cf8 into OpenRA:bleed Nov 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Nov 19, 2017

@MustaphaTR MustaphaTR deleted the MustaphaTR:d2k-harkonnen-6b branch Nov 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment