Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Harkonnen 6b #14288

Merged
merged 1 commit into from
Nov 19, 2017
Merged

Add Harkonnen 6b #14288

merged 1 commit into from
Nov 19, 2017

Conversation

MustaphaTR
Copy link
Member

No description provided.

Copy link
Contributor

@ltem ltem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mission plays like the original. Only the Smugglers will become your enemies if you attack their units (message pops up (see image)) but they won't send units against you. I've overlooked this in Harkonnen06a but it doesn't really change the gameplay and I think this isn't possible in OpenRA for now.
Edit1: I don't know how but learned it is possible to do in Lua, so maybe this can be added (later).

harkonnen6b_smugglershostile

After this is I'll approve this PR.

{ OrdosEntry9.Location, OrdosRally9.Location }
}

OrdosInterval =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I overlook something but what is OrdosInterval used for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FremenInterval was used by Sietchs producing fremen on All4 and Har4, it is not used in this, or other maps, looks like i just renamed and forget about it. I think 6a is merged with that, i'll remove it from both.

@MustaphaTR
Copy link
Member Author

I intentedly left out Smuggler side changing, in 6a too. It is not really important and lack of alliance changes make it unnecessarily complicated.

RA and TD mods campaign missions use Enemy Unit/Structure and no owner name. I'm planning to add that to D2K too, probably when Har Missions are all added. Maybe i add Smuggler Owner changes with it too.

@pchote
Copy link
Member

pchote commented Nov 11, 2017

Smugglers can be made hostile by setting up a second faction with different allies/enemies and switching all the actors over using lua.

@ltem
Copy link
Contributor

ltem commented Nov 11, 2017

Okay, I'm fine with that.

@abcdefg30
Copy link
Member

abcdefg30 commented Nov 12, 2017

Smugglers can be made hostile by setting up a second faction with different allies/enemies and switching all the actors over using lua.

Imho that is what should be done to retain the " Smugglers will become your enemies if you attack their units".

Edit: As requested by @penev92: Don't forget to remove the interval (#14288 (comment)) as well. ^^

@MustaphaTR
Copy link
Member Author

MustaphaTR commented Nov 18, 2017

Updated, added the Smuggler Owner/Stance change to both 6th missions, but still a bit different than original. You can't normally target the Smuggler units, but if you force fire on them or hit them by mistake, they turn against you.

Also Ordos may mistakely hit them and they can be enemy to ordos, without being an enemy to you. I remember that being case in the original, but not 100% sure. It makes more sense this way tho.

I made Smugglers non-combatant so their owner row won't be shown. I'll get rid of Owner Rows/Use Generic names with a future PR after getting all Harkonnen Missions merged, like other mods does anyway.

Copy link
Contributor

@ltem ltem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requests fixed and no more issues found.

@reaperrr reaperrr merged commit 7b12cf8 into OpenRA:bleed Nov 19, 2017
@reaperrr
Copy link
Contributor

changelog

@MustaphaTR MustaphaTR deleted the d2k-harkonnen-6b branch November 19, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants