New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for visibility when selecting AI superweapon targets. #14492

Merged
merged 5 commits into from Dec 22, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Dec 10, 2017

This fixes the single biggest complaint from casual players – that the TD airstrike always knows exactly the best target to hit. This also helps make the AI feel more like a real player, as it will fire the weapons where it think the enemy base is, which may no longer be accurate.

I have tested and tweaked TD's AI, but RA and D2K will need to be tested during review.

Adding to the milestone because this gives us a very nice user-facing feature to talk about in the news post.

Closes #7659.

@pchote pchote added this to the Next release milestone Dec 10, 2017

@@ -125,7 +125,7 @@ public int GetAttractiveness(Actor a, Stance stance, Player firedBy)
if (a == null)
return 0;
if (!a.IsTargetableBy(firedBy.PlayerActor))
if (!a.IsTargetableBy(firedBy.PlayerActor) || !a.CanBeViewedByPlayer(firedBy))

This comment has been minimized.

@penev92

penev92 Dec 10, 2017

Member

This looks like it belongs in the third commit?

@penev92

penev92 Dec 10, 2017

Member

This looks like it belongs in the third commit?

This comment has been minimized.

@pchote

pchote Dec 10, 2017

Member

Fixed.

@pchote

pchote Dec 10, 2017

Member

Fixed.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 11, 2017

Member

Rebased.

Member

pchote commented Dec 11, 2017

Rebased.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 13, 2017

Member

But we really should be able to handle that better.

I was trying to avoid touching an existing // HACK: HACK HACK HACK in the AI code, but you're right. Unfortunately I broke this rather thoroughly while trying to fix that, and don't have the time to correct and test it.

Member

pchote commented Dec 13, 2017

But we really should be able to handle that better.

I was trying to avoid touching an existing // HACK: HACK HACK HACK in the AI code, but you're right. Unfortunately I broke this rather thoroughly while trying to fix that, and don't have the time to correct and test it.

@pchote pchote removed the PR: Needs +2 label Dec 13, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 16, 2017

Member

Updated.

Member

pchote commented Dec 16, 2017

Updated.

@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Dec 19, 2017

Member

The rest looks good 👍

Member

penev92 commented Dec 19, 2017

The rest looks good 👍

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 21, 2017

Member

Rebased and added comment.

Member

pchote commented Dec 21, 2017

Rebased and added comment.

@penev92

+1

@abcdefg30 abcdefg30 merged commit 028f7c6 into OpenRA:bleed Dec 22, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Dec 22, 2017

@pchote pchote deleted the pchote:fix-ai-supportpower-maphack branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment