Add a total player count to the MP browser. #14610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phrohdoh
reviewed
Dec 31, 2017
| var playersLabel = widget.GetOrNull<LabelWidget>("PLAYER_COUNT"); | ||
| if (playersLabel != null) | ||
| { | ||
| var playersText = new CachedTransform<int, string>(c => c.ToString() + " Players Online"); |
There was a problem hiding this comment.
Nit: This will yield 1 Players Online if c is 1.
Please change this to either:
Player(s) Online, or- ternary
PlayervsPlayers
pchote
force-pushed
the
mp-playercount
branch
from
464ada0
to
b8538ab
Compare
abcdefg30
approved these changes
Jan 1, 2018
reaperrr
approved these changes
Jan 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A final bit of polish/functionality for the MP server browser:
Closes #13283.