Reuse TargetTypes collection in FrozenActor.RefreshState. #14917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchote
reviewed
Mar 15, 2018
| @@ -101,7 +101,8 @@ public FrozenActor(Actor actor, PPos[] footprint, Player viewer, bool startsReve | |||
| public void RefreshState() | |||
| { | |||
| Owner = actor.Owner; | |||
| TargetTypes = actor.GetEnabledTargetTypes().ToHashSet(); | |||
| TargetTypes.Clear(); | |||
There was a problem hiding this comment.
Can we include a // PERF: comment here?
|
Definitely a noticeable improvement, at least going by perf.log. On bleed, 52 entries in first 2000 ticks on shellmap, many of them with 3-7 ms. |
reaperrr
previously approved these changes
Mar 16, 2018
RoosterDragon
force-pushed
the
reuse-hashset-frozen-actor
branch
from
dc5cfd0
to
73081f0
Compare
reaperrr
approved these changes
Mar 17, 2018
chrisforbes
reviewed
Mar 18, 2018
|
|
||
| // PERF: Reuse collection to avoid allocations. | ||
| TargetTypes.Clear(); | ||
| TargetTypes.UnionWith(actor.GetEnabledTargetTypes()); |
There was a problem hiding this comment.
@RoosterDragon TargetTypes seems like a great candidate for load-time bitsetification.
There was a problem hiding this comment.
Interesting class. Is the idea you specify Bits<SomeMarkerStruct> TargetTypes in multiple places and it automatically converts everything as it's loaded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is called a lot, and saves us reallocating a new hash set each time. Hopefully helps with #14905.