Support for BurstDelays 0 #15761
Closed
Support for BurstDelays 0 #15761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceReaper
force-pushed
the
burstdelay0
branch
2 times, most recently
from
8cf3d70
to
d16025b
Compare
abcdefg30
reviewed
Oct 31, 2018
| @@ -186,6 +186,7 @@ public override void DoAttack(Actor self, Target target, IEnumerable<Armament> a | |||
| } | |||
|
|
|||
| foreach (var npa in self.TraitsImplementing<INotifyAttack>()) | |||
| foreach (var barrel in barrels) | |||
There was a problem hiding this comment.
This is missing one level of indentation.
IceReaper
force-pushed
the
burstdelay0
branch
from
d16025b
to
28b67be
Compare
|
updated |
|
Why close this? |
|
I had a rare occurence causing the game to freeze in an infinite loop. Didnt manage to find it. Ill reinvestigate this in a few weeks and redo the PR. |
pchote
reviewed
Nov 12, 2018
|
|
||
| if (ticksSinceLastShot >= Weapon.ReloadDelay) | ||
| Burst = Weapon.Burst; | ||
| while (CanFire(self, target)) |
There was a problem hiding this comment.
This will loop infinitely if the weapon has BurstDelays: 0, doesn't use an ammopool to pause the trait, and is in range and valid against the target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for weapons which fire a whole clip / burst at once, without a delay between the shots. This avoids the need for ugly hacks, giving actors for example 10 armaments if they have to shoot 10 shots at once.