Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent multiple Transforms from triggering in the same tick. #15889

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Prevent multiple Transforms from triggering in the same tick. #15889

merged 1 commit into from
Dec 8, 2018

Conversation

pchote
Copy link
Member

@pchote pchote commented Dec 5, 2018

This adds a simple workaround that should be good enough until a proper synchronous disposing can be implemented.

Fixes #15793.

@pchote pchote added this to the Hotfix release milestone Dec 5, 2018
@pchote pchote force-pushed the transform-disposing-workaround branch from 435119a to d8716d4 Compare December 5, 2018 21:57
abcdefg30
abcdefg30 approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@reaperrr reaperrr merged commit 4b6853b into OpenRA:bleed Dec 8, 2018
@reaperrr
Copy link
Contributor

reaperrr commented Dec 8, 2018

changelog

and picked to prep.

@pchote pchote deleted the transform-disposing-workaround branch January 26, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperrr reaperrr reaperrr approved these changes

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: For stable
Projects
None yet
Milestone
release-20181215
Development

Successfully merging this pull request may close these issues.
3 participants
@pchote @reaperrr @abcdefg30