Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #14013: App config for StyleCheck #16196

Merged
merged 1 commit into from Feb 22, 2019

Conversation

@portablestew
Copy link
Contributor

commented Feb 11, 2019

Fixes #14013

Running "make check" causes a ReflectionTypeLoadException to be thrown (at least, on my machine). The exception is that it cannot find the "OpenRA.Mods.Common" assembly. Only building from MonoDevelop seems to have this problem. Cleaning and rebuilding with "make all" allows "make check" to temporarily work again.

This PR copies the same "App.config" from OpenRA.Test, into OpenRA.StyleCheck. Since that config includes "mods/common" as a search path, the exception no longer occurs after building from MonoDevelop. I am unsure exactly how the two build processes differ.

@reaperrr
Copy link
Contributor

left a comment

I don't use MonoDevelop, but since it works for you and doesn't regress compiling on Windows on my end I see no reason to not merge this.

@pchote
pchote approved these changes Feb 22, 2019
Copy link
Member

left a comment

Repro case and fix confirmed 👍

@pchote pchote merged commit d592f37 into OpenRA:bleed Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@portablestew portablestew deleted the portablestew:stylecheck branch Feb 24, 2019

reaperrr added a commit to reaperrr/OpenRA that referenced this pull request Feb 28, 2019
Make git ignore StyleCheck.exe config
Since OpenRA#16196, this is automatically created on compile.
reaperrr added a commit to reaperrr/OpenRA that referenced this pull request Mar 3, 2019
reaperrr added a commit that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.