Fix for #14013: App config for StyleCheck #16196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperrr
approved these changes
Feb 22, 2019
pchote
approved these changes
Feb 22, 2019
reaperrr
added a commit
to reaperrr/OpenRA
that referenced
this pull request
Feb 28, 2019
Since OpenRA#16196, this is automatically created on compile.
reaperrr
added a commit
to reaperrr/OpenRA
that referenced
this pull request
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14013
Running "make check" causes a ReflectionTypeLoadException to be thrown (at least, on my machine). The exception is that it cannot find the "OpenRA.Mods.Common" assembly. Only building from MonoDevelop seems to have this problem. Cleaning and rebuilding with "make all" allows "make check" to temporarily work again.
This PR copies the same "App.config" from OpenRA.Test, into OpenRA.StyleCheck. Since that config includes "mods/common" as a search path, the exception no longer occurs after building from MonoDevelop. I am unsure exactly how the two build processes differ.