Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cancel parent activity when refinery is destroyed. #16853

Merged
merged 1 commit into from Jul 29, 2019

Conversation

tovl
Copy link
Contributor

@tovl tovl commented Jul 27, 2019

Fixes #16570.

Another case of direct activity queue manipulation leading to trouble. Completely superfluous to boot because HarvesterDockSequence already checks for the refinery state and knows how to exit gracefully when the refinery disappears.

@pchote pchote added this to the Next Release milestone Jul 28, 2019
Copy link
Contributor

@teinarss teinarss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teinarss teinarss merged commit 9e6f8ae into OpenRA:bleed Jul 29, 2019
@tovl tovl deleted the fix-docksequence branch December 15, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harvester become idle when refinery is destroyed during delivery
4 participants