Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing TS EMP issues #17097

Merged
merged 3 commits into from
Oct 5, 2019
Merged

Fixing TS EMP issues #17097

merged 3 commits into from
Oct 5, 2019

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Sep 15, 2019

Makes EMP disable Laser Fence
Makes Mobile Sensor Array lose detection on EMP
Makes subterranean units EMP-able while underground #17090

@tovl
Copy link
Contributor

tovl commented Sep 21, 2019

-Fixes laser fences and mobile sensor array.
-Doesn't fix landed aircraft being EMP-able (it only adds the visual overlay, but doesn't affect the behaviour at all).
-Makes subterranean units EMP-able, but they will not come to the surface.

The last two points cannot be fixed without engine changes, so I'd recommend to drop the third commit and leave that one to fix for later.

@PunkPun
Copy link
Member Author

PunkPun commented Sep 21, 2019

There's no reason to delay the third commit. When the engine changes are going to happen they will need to add it either way

@reaperrr
Copy link
Contributor

@punsho I picked your 3rd commit to #17136, so you can remove it (not a requirement, but it would save me a rebase).

@PunkPun
Copy link
Member Author

PunkPun commented Sep 22, 2019

@punsho I picked your 3rd commit to #17136, so you can remove it (not a requirement, but it would save me a rebase).

👍 removed it

Copy link
Contributor

@tovl tovl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@reaperrr reaperrr merged commit 460f5bb into OpenRA:bleed Oct 5, 2019
@PunkPun PunkPun deleted the EMP-issues branch March 16, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants