Fixed sonar pulse getting deployed on land

[Mailaender]

Closes #6145.
Closes #17371.

[pchote]

Unfortunately this leaks state through the shroud: the cursor tells the player whether a cell hidden under the shroud is water or something else. We will also need to limit this to cells that are either currently visible or perhaps visible + fog.

[Mailaender]

Added a shroud check.

[MlemandPurrs]

does Terrain= only accept a single type or a list of comma seperated terrain ? asking because, see:
#17371

[Mailaender]

A list of comma seperated terrain types.

[MustaphaTR]

Can we put these checks under base SupportPower instead of SpawnActorPower? i can see Terrain checks being used for other powers too.

[pchote]

Adding those kind of checks to SupportPower would not be a good idea. Some of our powers (e.g. ProduceActorPower, GrantPrerequisiteChargeDrainPower) do not have targeting cursors, so it does not make sense for them to expose terrain types.

This PR is only applying the checks in the client-side order targeting: this means that players can modify their client to allow them to target the power anywhere on the map without desyncing the game. The support power code does not expose a way for implementations to tell the manager that a targeting request is invalid and should be rejected - this is why the iron curtain and chronosphere misfires occur. We really should fix that before we try to proceed here.

[Orb370]

Maybe the cursor shouldn't change when it's on land? I think the name makes it pretty obvious it needs to be used in the water.

[obrakmann]

Works as advertised and seems reasonable. 👍

[abcdefg30]

We should also perform those checks in Activate before anything is done by the power. That will alleviate the cheating concerns.

[Mailaender]

Added the checks to activation as well.

[abcdefg30]

A few comments then this should be good to go. (Bonus points if you managed to reduce duplication.)

[Mailaender]

Removed the redundancy. I thought there might have been performance implications, but there aren't any.

[abcdefg30]

Changelog