Add support for net 5 for Windows

[teinarss]

Closes #12988.

[teinarss]

Im thiking that we should use dotnet build as default and have using msbuild as opt in.

We can use dotnet build for building core and mono as standard and then have the possibility to use msbuild on those platforms that dont have support for building with core (like different flavors of BSD).

pseudo code for the makefile

if parameter MSBUILD is not set then
    dotnet build TargetFramework=[netcore, netstandard]
else
    msbuild ...

We also need to have a parameter for which TargetFramework we want to build.

[pchote]

Something has regressed on macOS: i'm now seeing this error when trying to run dotnet OpenRA.Game.dll Game.Mod=cnc after compiling either through the commandline or with Rider.

Nevermind, its dotnet OpenRA.dll Game.Mod=cnc. My bad.

[RobFog]

Rebase needed.

[pchote]

Confirmed that this compiles and runs on OSX 10.9(!) with mono 6.10, so it looks like this now hits the compatibility goal i was hoping for 🙂

[pchote]

IMO it would be best if we could leave the packaging changes to followup PRs, where we can focus on one platform at a time.

What do you think about keeping mono as the default in this PR, with MONO=false as the opt-in, or keeping core as the default but then adding MONO=true to the packaging scripts?

[pchote]

Commenting out FrozenUnderFogUpdatedByGPS reveals a bunch of missing traits from Mods.Common:

Exception of type `OpenRA.YamlException`: ActorInfo("2tnk") failed to initialize because of the following:
Missing:
OpenRA.Mods.Common.Traits.BodyOrientationInfo 
Unresolved:
OpenRA.Mods.Common.Traits.Render.WithFacingSpriteBodyInfo: { OpenRA.Mods.Common.Traits.BodyOrientationInfo, OpenRA.Traits.IFacingInfo }
OpenRA.Mods.Common.Traits.Render.WithParachuteInfo: { OpenRA.Mods.Common.Traits.BodyOrientationInfo }
OpenRA.Mods.Common.Traits.HitShapeInfo: { OpenRA.Mods.Common.Traits.BodyOrientationInfo }
OpenRA.Mods.Common.Traits.AutoTargetInfo: { OpenRA.Mods.Common.Traits.AttackBaseInfo }
OpenRA.Mods.Common.Traits.AutoTargetPriorityInfo: { OpenRA.Mods.Common.Traits.AutoTargetInfo }
OpenRA.Mods.Common.Traits.AutoTargetPriorityInfo: { OpenRA.Mods.Common.Traits.AutoTargetInfo }
OpenRA.Mods.Common.Traits.TurretedInfo: { OpenRA.Mods.Common.Traits.BodyOrientationInfo }
OpenRA.Mods.Common.Traits.ArmamentInfo: { OpenRA.Mods.Common.Traits.AttackBaseInfo }
OpenRA.Mods.Common.Traits.AttackTurretedInfo: { OpenRA.Mods.Common.Traits.TurretedInfo }
OpenRA.Mods.Common.Traits.Render.WithMuzzleOverlayInfo: { OpenRA.Mods.Common.Traits.AttackBaseInfo, OpenRA.Mods.Common.Traits.ArmamentInfo }
OpenRA.Mods.Common.Traits.Render.WithSpriteTurretInfo: { OpenRA.Mods.Common.Traits.TurretedInfo, OpenRA.Mods.Common.Traits.BodyOrientationInfo, OpenRA.Mods.Common.Traits.ArmamentInfo }

[pchote]

Ok, this is still a problem in TD - it just doesn't crash on the shellmap because we aren't spawning any non-player actors there. It will crash with the same symptoms as soon as you try to start a skirmish.

[pchote]

It looks like your comment on IRC about loading multiple copies was correct. This seems to work 50309ab, but it would be cleaner if we can actually unload it?

[teinarss]

Updated.

[pchote]

Updated test builds: https://github.com/pchote/OpenRA/releases/tag/devtest-20201225
https://github.com/pchote/OpenRA/actions/runs/443934673

Rider isn't happy with this, ...

This can be fixed by going into Rider's Preferences → Toolset and Build → change "Use MSBuild version" from the mono MSBuild.dll to the dotnet one.

[Mailaender]

This depends on itchio/itch#2459

See https://github.com/teinarss/OpenRA/blob/netstandard21/packaging/.itch.toml#L1-L2

[pchote]

We ship self contained builds, so do not depend on any runtime prerequisites. The lines you've highlighted can simply be deleted.

[teinarss]

Updated.

[Mailaender]

I can't spot any problems on Linux so 👍🏻

[abcdefg30]

Changelog

[RobFog]

Should this be moved to the "Next Release" milestone?

[pchote]

No, this is going to be one of the main features for the release after next.

[RobFog]

Oh, okay.