Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts and packaging to support .NET 5. #171

Closed
wants to merge 1 commit into from

Conversation

pchote
Copy link
Member

@pchote pchote commented Jan 12, 2021

Adds compatibility for OpenRA/OpenRA#17989, OpenRA/OpenRA#18955, OpenRA/OpenRA#19026, OpenRA/OpenRA#19325, OpenRA/OpenRA#19389, OpenRA/OpenRA#19413. Filing as a draft now to help mods that want to track bleed, but this shouldn't be merged until we are ready to tag the next upstream prep branch.

@pchote
Copy link
Member Author

pchote commented Mar 6, 2021

When looping over ${PACKAGING_COPY_MOD_BINARIES} we also need to copy the .deps.json! (pdbs too). This otherwise breaks for mods that rely on any external dlls.

@pchote
Copy link
Member Author

pchote commented Mar 10, 2021

Scratch that - the whole approach of copying files out of engine/bin appears to be bogus and cause runtime crashes for OpenKrush. Changing this to use dotnet publish on the SDK sln should hopefully fix this.

@pchote
Copy link
Member Author

pchote commented Mar 15, 2021

The mono checks at the start of the launch scripts need to be updated to work with dotnet only setups.

@pchote pchote force-pushed the net5 branch 3 times, most recently from 4dce10f to cbcb639 Compare March 15, 2021 22:40
@pchote
Copy link
Member Author

pchote commented Mar 16, 2021

Need to rebase on latest bleed and add the --self-contained publish flag.

@OndroNR
Copy link

OndroNR commented Mar 17, 2021

There is missing dotnet check (as mono alternative) in utility.sh at start

@pchote pchote force-pushed the net5 branch 2 times, most recently from 94b347e to 58672a2 Compare March 17, 2021 21:46
make.ps1 Outdated Show resolved Hide resolved
@pchote
Copy link
Member Author

pchote commented Jul 18, 2021

@@ -66,12 +66,18 @@ MapGrid:

SpriteFormats: ShpTS

VideoFormats:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at it maybe add an empty SoundFormats: as well?

@Mailaender
Copy link
Member

This will install global mix database.dat even when PACKAGING_COPY_CNC_DLL="False". In the past you could simply remove it from PACKAGING_COPY_ENGINE_FILES.

@pchote
Copy link
Member Author

pchote commented Sep 25, 2021

The PACKAGING_COPY_ENGINE_FILES change happened in the last release (IIRC), and fixing it properly will require non-trivial changes to the upstream engine (allowing mods to specify a path to the mix database instead of assuming it is available in the engine root). It won't be possible to address that here.

@penev92
Copy link
Member

penev92 commented Dec 30, 2022

Superseded by #180.

@penev92 penev92 closed this Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants