Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weapons not accounting for Air #18166

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Conversation

reaperrr
Copy link
Contributor

If a weapon was aiming at a target position rather than an actor target, it would always check target types of the terrain below, ignoring altitude (and therefore ignoring InvalidTargets: Air).

Applying the same fix we already use on LeaveSmudge and CreateEffect warheads to weapons as well solves this.

Fixes #18147.

If a weapon was aiming at a target position rather
than an actor target, it would always check target types
of the terrain below, ignoring altitude (and therefore ignoring
"InvalidTargets: Air").
Copy link
Member

@Mailaender Mailaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Copy link
Member

@Smittytron Smittytron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@Mailaender Mailaender merged commit 0e81abc into OpenRA:bleed Jun 12, 2020
@Mailaender
Copy link
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weapons with BurstTargetOffsets will ignore valid/invalid target types
3 participants