-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added UI cursor configuration to chrome metric #18458
Conversation
Did you consider defining these on |
Yes, I tried a few things to keep this isolated to mod code only with custom button widgets which breaks as soon as I hit scroll panels which inherit the default button and also all UI configuration have to be forked. Changing the default and hacking view port controller and world interaction widget failed for me as those don't control all the cursors, they return null only for the |
5d73694
to
8c69dea
Compare
c175bf6
to
c1e6b48
Compare
c1e6b48
to
9227e3f
Compare
Can you please also squash the fixups after addressing that last issue? |
9227e3f
to
58224f4
Compare
The latest version appears to have reverted the earlier changes to remove WidgetDefaultCursor. |
You specifically asked for it in #18458 (comment) |
No, that example has WorldDefaultCursor, but specifically asked to remove WidgetDefaultCursor, which I then elaborated on further in #18458 (comment). You did that in the previous round of commits, but appear to have undone those changes possibly by force-pushing changes made on a stale local branch? |
58224f4
to
e3da50a
Compare
Ah now I see. Got confused there. Should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm otherwise.
e3da50a
to
e0174eb
Compare
e0174eb
to
b895321
Compare
This allows different cursors in menus and in-game.