Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloned widgets not having default cursor set #20450

Merged
merged 1 commit into from Nov 13, 2022
Merged

Fix cloned widgets not having default cursor set #20450

merged 1 commit into from Nov 13, 2022

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Nov 11, 2022 •
edited

Fixes #20413

#18458 forgot to support cloning for the newly added variable

@PunkPun PunkPun added this to the Next release milestone Nov 11, 2022
ThomasChr
ThomasChr approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@ThomasChr ThomasChr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move cursor on the left tabs and between the images is fixed, great!

But not this one:
image
This one is no regression - but maybe we can fix it in this PR too?

@PunkPun
Copy link
Member Author

PunkPun commented Nov 12, 2022

This one is no regression - but maybe we can fix it in this PR too?

This is not a related issue. The Widget.GetCursor method isn't called when you hover over that so the issue isn't with cursors

@ThomasChr
Copy link
Contributor

This is not a related issue. The Widget.GetCursor method isn't called when you hover over that so the issue isn't with cursors

Fine by me - shall we open another issue then?

@Smittytron Smittytron merged commit 243e2b2 into OpenRA:bleed Nov 13, 2022
@PunkPun PunkPun deleted the fix-widgets branch November 13, 2022 21:07
@Smittytron
Copy link
Member

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasChr ThomasChr ThomasChr approved these changes

@Smittytron Smittytron Smittytron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 20230225
Development

Successfully merging this pull request may close these issues.

Misclick through sidebar
3 participants
@PunkPun @ThomasChr @Smittytron