Enable the restart button for missions with script errors #18602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be the same problem with no client id 0 existing. |
|
#18902 was included in playtest-20201213, and should have fixed that. Since we don't have an obvious way forward here i'll close this to help clean up the PR queue. We can reopen this if anyone has any ideas on how to reproduce or debug the desyncs. |
abcdefg30
changed the title
|
Dropped the offending commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17540.
Edit: #14104 is still open.I didn't encounter a desync when restarting a multiplayer replay, but I also don't know the reproduction case of #15423 (comment).