Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support random factions and spawn points in server replays. #18696

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Support random factions and spawn points in server replays. #18696

merged 1 commit into from
Oct 31, 2020

Conversation

pchote
Copy link
Member

@pchote pchote commented Oct 10, 2020

This PR extends #17578 with the ability for server replays to resolve random faction and spawn point assignments.

Depends on #18672.

@pchote pchote added this to the Next Release milestone Oct 10, 2020
@pchote pchote force-pushed the server-replay-factions branch 2 times, most recently from 1de8f03 to 3714faf Compare October 13, 2020 18:46
@pchote
Copy link
Member Author

pchote commented Oct 13, 2020

Rebased and ready for review.

@pchote
Copy link
Member Author

pchote commented Oct 13, 2020

Updated OccupiedSpawnPoints.

abcdefg30
abcdefg30 requested changes Oct 19, 2020
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is not correct with the spawn resolving on the server side.
Client recorded (correct display):
grafik
Server recorded (incorrect):
grafik

@pchote
Copy link
Member Author

pchote commented Oct 19, 2020

Looks like the server side might be rejecting the nonselectable Allies faction, which then throws off the RNG state.

@pchote
Copy link
Member Author

pchote commented Oct 19, 2020

Fixed.

@deleted-user-1 deleted-user-1 mentioned this pull request Oct 26, 2020
Closed
@pchote
Copy link
Member Author

pchote commented Oct 30, 2020

It would be good to get this merged to unblock #18425.

@abcdefg30 abcdefg30 merged commit 6b6b1e5 into OpenRA:bleed Oct 31, 2020
@abcdefg30
Copy link
Member

Changelog

@pchote pchote mentioned this pull request Oct 31, 2020
Merged
@pchote pchote deleted the server-replay-factions branch December 6, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20210321
Development

Successfully merging this pull request may close these issues.
2 participants
@pchote @abcdefg30