Fix AI air squad misbehaving in TS maps

[dnqbob]

Fixes #18705

I divide two scanning method into two if. I think the array is unnecessary for RectangularIsometric maps and may save some performance before we come out with better idea.

[pchote]

The real problem here is that the squad code is mixing up CPos versus MPos coordinates.

Replacing

var pos = new CPos((i % columnCount) * dangerRadius + dangerRadius / 2, (i / columnCount) * dangerRadius + dangerRadius / 2);

with

var pos = new MPos((i % columnCount) * dangerRadius + dangerRadius / 2, (i / columnCount) * dangerRadius + dangerRadius / 2).ToCPos(map);

may be a much simpler workaround for the issue. MPos and CPos are equivalent for MapGridType.Rectangular so there should be no changes in behaviour there.

[pchote]

This is a natural part two to #17855, so really should be on the milestone.

[dnqbob]

The real problem here is that the squad code is mixing up CPos versus MPos coordinates.

Replacing

var pos = new CPos((i % columnCount) * dangerRadius + dangerRadius / 2, (i / columnCount) * dangerRadius + dangerRadius / 2);

with

var pos = new MPos((i % columnCount) * dangerRadius + dangerRadius / 2, (i / columnCount) * dangerRadius + dangerRadius / 2).ToCPos(map);

may be a much simpler workaround for the issue. MPos and CPos are equivalent for MapGridType.Rectangular so there should be no changes in behaviour there.

Don't know if that is working. But I will have a try.

[dnqbob]

@pchote
Tested. it is fixed.

[pchote]

Not tested, but the code change looks correct.

[abcdefg30]

The AI still behaves weird with air units, but this change is not making it worse (and makes sense).

[abcdefg30]

Changelog

[dnqbob]

The AI still behaves weird with air units, but this change is not making it worse (and makes sense).

So AI air squad still won't attack when enemy actors at certain side of map? during my test it seems OK, although the target they pick become weird.

[abcdefg30]

They still sometimes start to idle, or don't reload. See #6316.

[dnqbob]

They will land and take off immediately especially when the bot's base is under attack

In fact, when bot's base under attack the aircraft is controlled by protection squad, which overtake controls from air squad. You can use #17999 to fix. (#18039 also help a little bit on reload part for aircraft in protection squad)
update:
The former protection squad is simply grab a bunch of units, no matter it is air or ground and attackmove to target until target die. Then you will find aircraft running out of ammo try step to the head of enemy (AttackMove)