Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MasterServerPinger to modern approach #18947

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Update MasterServerPinger to modern approach #18947

merged 1 commit into from
Dec 22, 2020

Conversation

teinarss
Copy link
Contributor

No description provided.

@pchote
Copy link
Member

pchote commented Dec 20, 2020 

Checking runtime assemblies...
error: The following assemblies are referenced but not whitelisted:
   System.Net.Http.dll

The makefile whitelist and packaging scripts will need to include this!

@teinarss teinarss force-pushed the fix_masterserverpinger branch 2 times, most recently from 31964e5 to 134d39e Compare December 20, 2020 18:27
pchote
pchote reviewed Dec 21, 2020
View reviewed changes
packaging/functions.sh Outdated Show resolved Hide resolved
@teinarss
Copy link
Contributor Author

Updated.

@pchote
Copy link
Member

pchote commented Dec 22, 2020

The changelog for this should be part of a more generic "Switch Windows releases to .NET 5" entry.

abcdefg30
abcdefg30 approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@abcdefg30 abcdefg30 merged commit 73bba97 into OpenRA:bleed Dec 22, 2020
@abcdefg30
Copy link
Member

Changelog

@pchote pchote mentioned this pull request Dec 23, 2020
Merged
@teinarss teinarss deleted the fix_masterserverpinger branch April 15, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote approved these changes

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: Is Dependency PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teinarss @pchote @abcdefg30