Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-sheet/palette rendering to TerrainSpriteLayer #18982

Merged
merged 4 commits into from
Jan 16, 2021
Merged

Add multi-sheet/palette rendering to TerrainSpriteLayer #18982

merged 4 commits into from
Jan 16, 2021

Conversation

pchote
Copy link
Member

@pchote pchote commented Dec 29, 2020 •
edited
Loading

This PR extends #15194 to cover TerrainSpriteLayer, which removes several annoying restrictions.

  • Fixes the unclear "sprites span multiple sheets" exceptions that force modders to reorganize their sequence definitions
  • Removes the batch overhead from mixing palettes in tilesets
  • Allows mods to mix indexed and 32bit artwork in the same tileset
  • Fixes Support for Depth Enabled RGBA Terrain #18333

Depends on #18728.

Also needed for further optimizations when using the remaster assets.

Testcases:

  • TD: replaces temperate clear tiles with desert (shows that palettes can be mixed without increasing the batch count)
  • RA: splits the resource definitions onto different sheets (shows that this no longer crashes)
  • TS: replaces temperate clear tiles with RGBA + 8bit depth snow tiles (shows that Support for Depth Enabled RGBA Terrain #18333 is solved)

@pchote pchote mentioned this pull request Dec 31, 2020
Merged
This was referenced Jan 6, 2021
Merged
Closed
@pchote
Copy link
Member Author

pchote commented Jan 11, 2021

Rebased and ready for review.

@pchote
Copy link
Member Author

pchote commented Jan 14, 2021 •
edited
Loading

Updated.

@pchote
Copy link
Member Author

pchote commented Jan 14, 2021

Updated.

@pchote pchote requested a review from teinarss January 14, 2021 23:52
teinarss
teinarss previously approved these changes Jan 15, 2021
View reviewed changes
@reaperrr
Copy link
Contributor

👍
Testcases can be removed now.

@pchote
Copy link
Member Author

pchote commented Jan 16, 2021

Testcases removed.

@reaperrr reaperrr merged commit 223a001 into OpenRA:bleed Jan 16, 2021
@reaperrr
Copy link
Contributor

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/f485569a4d3bc28c7d0f367f6588ecd2d9ceabf6...a2e2feb755c43a9cc6dfe859a2d911d72eebb3fc

@pchote pchote mentioned this pull request Jan 21, 2021
Closed
@pchote pchote deleted the vb-multitexture branch April 8, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperrr reaperrr reaperrr approved these changes

@teinarss teinarss teinarss left review comments

Assignees
No one assigned
Labels
PR: Is Dependency PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Depth Enabled RGBA Terrain
3 participants
@pchote @reaperrr @teinarss