Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom palettes from building placement previews. #18942

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

pchote
Copy link
Member

@pchote pchote commented Dec 19, 2020

Building on #18550, this PR replaces the custom palettes in PBOG previews with an explicit alpha value to make them compatible with with 32bit sprites.

The testcase commit demonstrates that target flashes and WithColoredOverlay (from #18550) and building placement previews work as expected for the D2k R16 sprites (loaded as 32bit). You will need to provide your own R16 files from an original game install.

@pchote
Copy link
Member Author

pchote commented Jan 6, 2021

Rebased and ready for review.

I have moved the testcase to https://github.com/pchote/OpenRA/tree/d2k-r16 where it can benefit from the mixed RGBA/Indexed terrain support from #18982 and also demonstrate #19012.

@pchote pchote force-pushed the alpha-placebuilding branch 2 times, most recently from 089665a to 88e2245 Compare January 11, 2021 21:40
@pchote
Copy link
Member Author

pchote commented Jan 13, 2021

Fixed.

teinarss
teinarss previously approved these changes Jan 14, 2021
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo it would be good if the update rule mentioned the locations it removed nodes at (as we usually do) since it does not automatically replace the values.

@pchote
Copy link
Member Author

pchote commented Jan 31, 2021

Rebased and updated.

New update messages:

RemovePlaceBuildingPalette: *PlaceBuildingPreview palette overrides have been removed.
   Updating mod... COMPLETE
   Updating system maps... COMPLETE
   Manual changes are required to complete this update:
    * The *Palette fields have been removed from the *PlaceBuildingPreview traits.
      You may wish to inspect the following definitions and define new Alpha or
      LineBuildSegmentAlpha properties as appropriate to recreate transparency effects:
       * ^Building (rules/defaults.yaml)
       * ^Wall (rules/defaults.yaml)
       * WEAP (rules/structures.yaml)
       * SAM (rules/structures.yaml)

@reaperrr reaperrr merged commit d09476c into OpenRA:bleed Feb 12, 2021
@pchote pchote deleted the alpha-placebuilding branch April 8, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants