-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom palettes from building placement previews. #18942
Conversation
7c9e054
to
ad47266
Compare
8b1d9b8
to
644b621
Compare
644b621
to
847f676
Compare
847f676
to
57548e3
Compare
Rebased and ready for review. I have moved the testcase to https://github.com/pchote/OpenRA/tree/d2k-r16 where it can benefit from the mixed RGBA/Indexed terrain support from #18982 and also demonstrate #19012. |
089665a
to
88e2245
Compare
OpenRA.Mods.Common/Traits/Buildings/FootprintPlaceBuildingPreview.cs
Outdated
Show resolved
Hide resolved
88e2245
to
6ab0c81
Compare
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo it would be good if the update rule mentioned the locations it removed nodes at (as we usually do) since it does not automatically replace the values.
OpenRA.Mods.Common/Traits/Buildings/ActorPreviewPlaceBuildingPreview.cs
Outdated
Show resolved
Hide resolved
6ab0c81
to
4c09729
Compare
4c09729
to
0516bc9
Compare
0516bc9
to
ff8cd40
Compare
Rebased and updated. New update messages:
|
Building on #18550, this PR replaces the custom palettes in PBOG previews with an explicit alpha value to make them compatible with with 32bit sprites.
The testcase commit demonstrates that target flashes and WithColoredOverlay (from #18550) and building placement previews work as expected for the D2k R16 sprites (loaded as 32bit). You will need to provide your own R16 files from an original game install.